Feature distributed fused adam and distributed fused lamb #188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Updated feature of distributed fused adam from upstream. Updated its dependencies - fused adam, distributed adam. Updated the unit test case for distributed fused adam. * Raise Exception when nccl user buffer / cuda graph is used in distributed fused adam. Skipped these particular UTs * Adding support for rccl_ub in distributed_fused_adam * build nccl_allocator module when cuda_ext flag is mentioned
amd-sriram
added a commit
to ROCm/pytorch
that referenced
this pull request
Mar 25, 2025
Altering the flag to use the correct streamType for CUDAPluggableAllocator. This is impacting Distributed Fused Adam in Rocm/APEX. Apex Commit : ROCm/apex#188
|
This should also be approved. |
jithunnair-amd
pushed a commit
to ROCm/pytorch
that referenced
this pull request
Mar 26, 2025
Altering the flag to use the correct streamType for CUDAPluggableAllocator. This is impacting Distributed Fused Adam in Rocm/APEX. `2025-03-25T14:19:25.0187731Z #5 1815.5 FAILED: /root/dockerbuild/pytorch.1.7.0a0/apex/build/temp.linux-x86_64-cpython-312/apex/contrib/csrc/nccl_allocator/NCCLAllocator_hip.o` ``` torch/include/torch/csrc/cuda/CUDAPluggableAllocator.h:125:8: error: ‘void torch::cuda::CUDAPluggableAllocator::CUDAPluggableAllocator::recordStream(const c10::DataPtr&, torch::cuda::CUDAPluggableAllocator::streamType)’ marked ‘override’, but does not override 2025-03-25T14:19:25.0192670Z #5 1815.5 125 | void recordStream(const c10::DataPtr&, streamType stream) override; 2025-03-25T14:19:25.0192737Z #5 1815.5 | ^~~~~~~~~~~~ ``` Apex Commit : ROCm/apex#188
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated feature of distributed fused adam from upstream. Updated its dependencies - fused adam, distributed adam. Updated the unit test case for distributed fused adam.
Raise Exception when nccl user buffer / cuda graph is used in distributed fused adam. Skipped these particular UTs
Adding support for rccl_ub in distributed_fused_adam
build nccl_allocator module when cuda_ext flag is mentioned
Commits :
6fd8b50
ccb59d6