Skip to content

[release/2.5] Update CUDAPluggableAllocator.h #1999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 26, 2025

Conversation

amd-sriram
Copy link

@amd-sriram amd-sriram commented Mar 25, 2025

Altering the flag to use the correct streamType for CUDAPluggableAllocator. This is impacting Distributed Fused Adam in Rocm/APEX.

To fix the following error when building apex:
2025-03-25T14:19:25.0187731Z #5 1815.5 FAILED: /root/dockerbuild/pytorch.1.7.0a0/apex/build/temp.linux-x86_64-cpython-312/apex/contrib/csrc/nccl_allocator/NCCLAllocator_hip.o

torch/include/torch/csrc/cuda/CUDAPluggableAllocator.h:125:8: error: ‘void torch::cuda::CUDAPluggableAllocator::CUDAPluggableAllocator::recordStream(const c10::DataPtr&, torch::cuda::CUDAPluggableAllocator::streamType)’ marked ‘override’, but does not override
2025-03-25T14:19:25.0192670Z #5 1815.5   125 |   void recordStream(const c10::DataPtr&, streamType stream) override;
2025-03-25T14:19:25.0192737Z #5 1815.5       |        ^~~~~~~~~~~~

Apex Commit : ROCm/apex#188

Altering the flag to use the correct streamType for CUDAPluggableAllocator. This is impacting Distributed Fused Adam in Rocm/APEX.


Apex Commit : ROCm/apex#188
@rocm-repo-management-api
Copy link

rocm-repo-management-api bot commented Mar 25, 2025

Jenkins build for 5743a0cc85f7de5c8d42b14d28bc1941dfeb875c commit finished as FAILURE
Links: Blue Ocean view / Build artifacts

@jithunnair-amd
Copy link
Collaborator

This makes sense to me since when Apex (or any extension) includes the header, TORCH_HIP_VERSION is not defined, but USE_ROCM is.

@jithunnair-amd jithunnair-amd merged commit 6d856c2 into release/2.5 Mar 26, 2025
5 of 7 checks passed
@jithunnair-amd jithunnair-amd deleted the update_flag_streamType branch March 26, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants