Skip to content

Make sampled_addmm_out_sparse_csr and spmm compatible with hipSparse >= 2.4.0 #1283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

xinyazhang
Copy link

Fixes #SWDEV-420269

Tested with CI=1 PYTORCH_TEST_WITH_ROCM=1 python3 test/run_test.py --continue-through-error --verbose -i test_sparse test_sparse_csr --use-pytest
All tests passed:

xmllint --xpath '//testsuites/testsuite/@*' test_sparse/test_sparse-807071f7b5dbf692.xml  test_sparse_csr/test_sparse_csr-bc83509a402772ff.xml 
 name="pytest"
 errors="0"
 failures="0"
 skipped="345"
 tests="2799"
 time="163.612"
 timestamp="2023-09-14T19:28:32.475896"
 hostname="eaeb070677c3"
 name="pytest"
 errors="0"
 failures="0"
 skipped="729"
 tests="4751"
 time="263.728"
 timestamp="2023-09-14T19:31:23.585087"
 hostname="eaeb070677c3"

@pruthvistony
Copy link
Collaborator

Needs to cherry-pick this commit into rocm6.0_internal_testing branch.

@pruthvistony pruthvistony merged commit 795e2b0 into rocm5.7_internal_testing_with_rocm6.0_fixes Sep 18, 2023
pruthvistony pushed a commit that referenced this pull request Oct 11, 2023
@pruthvistony
Copy link
Collaborator

Cherry-picked to rocm6.0_internal_testing branch.

pruthvistony pushed a commit that referenced this pull request Dec 6, 2023
pruthvistony pushed a commit that referenced this pull request Jan 21, 2024
pruthvistony pushed a commit that referenced this pull request Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants