Skip to content

skip test_baddbmm_cuda_* for ROCm for release/1.13 #1371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

dnikolaev-amd
Copy link

release/1.13 is very old to fix, just skip test for ROCm
newer versions were fixed by this PR #1283

Copy link
Collaborator

@pruthvistony pruthvistony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skipping the UT is OK for release/1.13 branch, since we dont want to spend more time on cherry-picking all the changes from newer branches into this old release/1.13 branch.

@dnikolaev-amd dnikolaev-amd marked this pull request as ready for review March 19, 2024 18:41
@dnikolaev-amd dnikolaev-amd merged commit 6297396 into release/1.13 Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants