Skip to content

Support SCRIPTRUN with variadic INPUTS #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from

Conversation

sazzad16
Copy link
Contributor

No description provided.

@sazzad16 sazzad16 force-pushed the scriptrun-variadic-inputs branch from cbbf958 to cb09a38 Compare April 27, 2021 14:28
@filipecosta90
Copy link
Collaborator

@sazzad16if you can fix the error

docker: Error response from daemon: pull access denied for redisai/redisai, repository does not exist or may require 'docker login': denied: requested access to the resource is denied.

we can approve.

@sazzad16
Copy link
Contributor Author

@filipecosta90 We should do it outside this PR. I can see that @DvirDukhan is trying in #29. But it is generating

com.redislabs.redisai.RedisAIException: redis.clients.jedis.exceptions.JedisDataException: ERR Could not load backend
	at com.redislabs.redisai.RedisAITest.testSetModelFromModelTFLite(RedisAITest.java:202)
Caused by: redis.clients.jedis.exceptions.JedisDataException: ERR Could not load backend
	at com.redislabs.redisai.RedisAITest.testSetModelFromModelTFLite(RedisAITest.java:202)

Is there any change in TFLITE?

@DvirDukhan
Copy link
Contributor

@filipecosta90

  1. This PR is Irrelevant as script execute command redis-inference-optimization#682 will be merge soon
  2. We have a docker issue with TFLite - fixed at docker build - change buster to bionic redis-inference-optimization#707

@sazzad16
Copy link
Contributor Author

@filipecosta90 The issue is in RedisAI docker TFLITE. That's out of my hand.

@filipecosta90 filipecosta90 added the wontfix This will not be worked on label Apr 28, 2021
@codecov
Copy link

codecov bot commented Apr 28, 2021

Codecov Report

Merging #30 (948692a) into master (e7cab06) will decrease coverage by 0.10%.
The diff coverage is 92.59%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #30      +/-   ##
==========================================
- Coverage   87.62%   87.52%   -0.11%     
==========================================
  Files          12       12              
  Lines         598      617      +19     
  Branches       83       87       +4     
==========================================
+ Hits          524      540      +16     
- Misses         34       35       +1     
- Partials       40       42       +2     
Impacted Files Coverage Δ
src/main/java/com/redislabs/redisai/RedisAI.java 82.29% <92.59%> (+0.78%) ⬆️
src/main/java/com/redislabs/redisai/Script.java 91.17% <0.00%> (-1.48%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7cab06...948692a. Read the comment docs.

@gkorland gkorland requested a review from DvirDukhan April 28, 2021 14:47
@sazzad16 sazzad16 closed this Jul 6, 2021
@sazzad16 sazzad16 deleted the scriptrun-variadic-inputs branch July 8, 2021 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants