Skip to content

docker build - change buster to bionic #707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

alonre24
Copy link
Collaborator

  • need to see if there are more places that need to be changed

@alonre24 alonre24 requested a review from chayim April 27, 2021 07:47
@codecov
Copy link

codecov bot commented Apr 27, 2021

Codecov Report

Merging #707 (cc58659) into master (a874faf) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #707   +/-   ##
=======================================
  Coverage   78.90%   78.90%           
=======================================
  Files          43       43           
  Lines        6850     6850           
=======================================
  Hits         5405     5405           
  Misses       1445     1445           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fda8e30...cc58659. Read the comment docs.

Copy link
Contributor

@chayim chayim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also edit opt/build/docker/Makefile (see line 7). You're going to also want to edit Dockerfile.gpu at the root of the repo.

It's best to make these consistent - even if there's variable use.

@alonre24
Copy link
Collaborator Author

alonre24 commented May 3, 2021

Rafi updates the redisfab image instead - closed.

@alonre24 alonre24 closed this May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants