-
Notifications
You must be signed in to change notification settings - Fork 106
Closed
Labels
Description
The latest push to master introduce a regression that causes RedisAI to crash when doing MODELSCAN
. Interestingly, if the MODELSET
is tagged, it doesn't crash. I haven't looked into the core for the exact crash issue yet but made a script to reproduce if anybody else has time (run it from the root of redisai-py
to match the relative path to the provided model)
from ml2rt import load_model
from redisai import Client
con = Client()
model_path = 'test/testdata/'
ptmodel = load_model(model_path + "pt-minimal.pt")
def core_dump_when_not_tagged():
con.modelset("pt_model", 'torch', 'cpu', ptmodel)
con.modelscan()
def no_core_dump_when_tagged():
con.modelset("pt_model", 'torch', 'cpu', ptmodel, tag='v1.0')
con.modelscan()
if __name__ == "__main__":
no_core_dump_when_tagged()
core_dump_when_not_tagged()
Crash on SCRIPTSCAN is also easy to reproduce