Skip to content

Conversation

lantiga
Copy link
Contributor

@lantiga lantiga commented Dec 22, 2020

Fixes #541

@codecov
Copy link

codecov bot commented Dec 22, 2020

Codecov Report

Merging #542 (5021945) into master (740bbba) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #542      +/-   ##
==========================================
+ Coverage   75.33%   75.35%   +0.02%     
==========================================
  Files          22       22              
  Lines        5221     5226       +5     
==========================================
+ Hits         3933     3938       +5     
  Misses       1288     1288              
Impacted Files Coverage Δ
src/model.c 71.62% <100.00%> (ø)
src/redisai.c 80.00% <100.00%> (+0.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 740bbba...5021945. Read the comment docs.

alonre24
alonre24 previously approved these changes Dec 22, 2020
@lantiga
Copy link
Contributor Author

lantiga commented Dec 22, 2020

Adding the test, don't merge yet thx

@lantiga
Copy link
Contributor Author

lantiga commented Dec 22, 2020

Done, ready to go

@lantiga lantiga requested a review from alonre24 December 22, 2020 10:46
@lantiga lantiga merged commit e06c663 into master Dec 22, 2020
@lantiga lantiga deleted the modelscan-fix branch December 22, 2020 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RedisAI crashes on MODELSCAN & SCRIPTSCAN
3 participants