String tensor support #832

alonre24 · 2021-08-22T12:35:07Z

We introduce string tensor for RedisAI, which are tensors in which every element is a null-terminated string (we support utf-8 format).
This PR adds the following capabilities:

store and retrive string tensors in RedisAI by using the known API: AI_TENSORSET <KEY> string <shape_1> [<shape_2> ...] [BLOB <blob> | VALUES <str_1> ...]
Run ONNX models whose inputs/outputs are string tensors

todo:

Enable running TF models whose inputs/outputs are string tensors
Add string tensor support to LLAPI (?)

…disAI into string_tensor_support

codecov · 2021-08-23T07:41:03Z

Codecov Report

Merging #832 (2b3f391) into master (de0f302) will increase coverage by 1.24%.
The diff coverage is 91.37%.

@@            Coverage Diff             @@
##           master     #832      +/-   ##
==========================================
+ Coverage   79.97%   81.22%   +1.24%     
==========================================
  Files          53       55       +2     
  Lines        8009     8126     +117     
==========================================
+ Hits         6405     6600     +195     
+ Misses       1604     1526      -78

Impacted Files	Coverage Δ
src/serialization/AOF/rai_aof_rewrite.c	`0.00% <0.00%> (ø)`
.../serialization/RDB/decoder/previous/v2/decode_v2.c	`46.56% <0.00%> (+9.81%)`	⬆️
src/execution/parsing/deprecated.c	`81.18% <66.66%> (+1.48%)`	⬆️
...c/serialization/RDB/decoder/current/v4/decode_v4.c	`71.42% <71.42%> (ø)`
.../serialization/RDB/decoder/previous/v0/decode_v0.c	`63.33% <72.72%> (+1.69%)`	⬆️
tests/module/LLAPI.c	`75.83% <79.01%> (+1.36%)`	⬆️
src/serialization/RDB/encoder/v4/encode_v4.c	`85.96% <81.81%> (ø)`
src/backends/tensorflow.c	`72.16% <91.00%> (+3.12%)`	⬆️
src/backends/onnxruntime.c	`78.80% <91.86%> (+1.42%)`	⬆️
src/redis_ai_objects/tensor.c	`91.72% <94.52%> (+5.03%)`	⬆️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53f16b6...2b3f391. Read the comment docs.

DvirDukhan

please see tensor.h/tensor.c comments

please add:

script to create onnx model
DAG tests
v4 encoding

.circleci/config.yml

src/backends/tensorflow.c

tests/flow/tests_common.py

tests/flow/tests_onnx.py

src/redis_ai_objects/tensor.c

DvirDukhan · 2021-08-23T21:56:02Z

src/redis_ai_objects/tensor.c

+size_t RAI_TensorByteSize(RAI_Tensor *t) {
+    // TODO: as per dlpack it should be
+    //   size *= (t->dtype.bits * t->dtype.lanes + 7) / 8;
+    // todo: change after verify that blob size is initialized properly


This upper TODO is old (Luca?), and I don't really understand what it means. Should I remove it?
About the other todo - will do.

src/redis_ai_objects/tensor.c

src/backends/onnxruntime.c

tests/flow/tests_deprecated_commands.py

tests/flow/tests_onnx.py

tests/flow/tests_dag_errors.py

src/serialization/RDB/decoder/previous/v0/decode_v0.c

src/redis_ai_objects/tensor.c

src/redis_ai_objects/tensor.h

… remove deep copy (not used)

src/backends/onnxruntime.c

DvirDukhan · 2021-09-05T07:22:19Z

tests/flow/test_data/onnx_string_identity.py

@@ -1,29 +1,6 @@
 import onnx
 from onnx import helper, TensorProto, ModelProto, defs

-
-def make_model(graph, **kwargs):  # type: (GraphProto, **Any) -> ModelProto


let's validate ONNX versions vs ONNXRuntime versions here please

Validated - using ONNX 1.8.0 when running this script will create a model that runs properly on ONNXRuntime 1.8.1.
Note that if we use ONNX latest (1.10.1), Opset version is 15, while ONNXRuntime 1.8.1 supports up to 14. I assume that ONNXRumtime will support Opset version 15...

tests/module/LLAPI.c

tests/flow/tests_tensorflow.py

src/backends/tensorflow.c

…disAI into string_tensor_support

DvirDukhan · 2021-09-06T09:50:05Z

docs/commands.md

+redis> AI.TENSORSET mytensor STRING 1 2 VALUES first second
+OK


please have a dedicated section regarding strings
how they should be provided by blob and by values.
consider doing so in a different PR involving documentation for BOOL

OK, will do in a new PR

src/redis_ai_objects/tensor.c

src/serialization/RDB/decoder/current/v4/decode_v4.c

src/serialization/RDB/decoder/previous/v0/decode_v0.c

tests/flow/tests_tensorflow.py

…d) + small fixes

alonre24 added 19 commits August 15, 2021 16:15

Refactor tensor set (wip)

ed15d65

Support string tensor in tensor set (wip)

3b7d984

Refactor tensor set (wip)

db207d4

Refactor tensor set (wip)

7651886

Refactor tensor set (wip)

31568ef

Refactor tensor set (wip)

e9155c8

Refactor tensor set (wip)

6cbe718

Refactor tensor set (wip)

aa23ccc

Refactor tensor set (wip)

7de9e54

Refactor tensor set (wip)

7bdc2f7

Refactor tensor set (wip)

606812d

Refactor tensor set (wip)

db5d30a

Refactor tensor set (wip)

0b94d62

formatting

aac7798

Merge branch 'master' into string_tensor_support

cb490d6

Merge branch 'master' into string_tensor_support

07b3843

Merge branch 'master' into string_tensor_support

0f77970

fixed bug in creating scalar tensor (with 0 dims)

0b61167

Merge branch 'string_tensor_support' of https://github.com/RedisAI/Re…

4893b84

…disAI into string_tensor_support

alonre24 requested a review from DvirDukhan August 23, 2021 06:12

all caches are the same cache now

b504e01

alonre24 added the ci-test label Aug 23, 2021

DvirDukhan requested changes Aug 23, 2021

View reviewed changes

chayim added ci-test and removed ci-test labels Aug 24, 2021

alonre24 added 4 commits August 24, 2021 15:04

PR fixes - WIP

8940c82

WIP - PR comments

00b2f96

WIP - PR comments

01dc09c

WIP - PR comments

adaa680

fix - set unknown blob_size to be 0.

794bbdf

DvirDukhan reviewed Aug 31, 2021

View reviewed changes

alonre24 added 9 commits August 31, 2021 15:52

wip

42369fd

PR fixes + testing string tensor concatenation and slicing via LLAPI,…

db903a4

… remove deep copy (not used)

support TF - WIP

705ee47

support TF - WIP

e31d1aa

support and test TF

b8b3e19

revert onnx model

fbbb4e7

Document test

cb835ab

upload the TF model created for testing

e548cc1

Merge branch 'master' into string_tensor_support

4baceca

DvirDukhan reviewed Sep 5, 2021

View reviewed changes

alonre24 added 3 commits September 5, 2021 14:27

PR fixes - WIP

1929bf6

PR fixes

11c4948

Merge branch 'string_tensor_support' of https://github.com/RedisAI/Re…

acaa815

…disAI into string_tensor_support

alonre24 added ci-test and removed ci-test labels Sep 5, 2021

valgrind fixes

eebffc3

alonre24 added ci-test and removed ci-test labels Sep 5, 2021

Add string tensor type to docs

848ef81

alonre24 removed the ci-test label Sep 6, 2021

DvirDukhan reviewed Sep 6, 2021

View reviewed changes

alonre24 added 2 commits September 6, 2021 15:35

Extended TF test description

8a1d3b7

Small refactor of RDB encode/decode (so we won't copy blob on rdb loa…

2b3f391

…d) + small fixes

alonre24 added the ci-test label Sep 9, 2021

DvirDukhan approved these changes Sep 9, 2021

View reviewed changes

alonre24 mentioned this pull request Sep 9, 2021

Documenting string and bool tensor types + validate bool blob #842

Merged

alonre24 merged commit d2565ac into master Sep 10, 2021

alonre24 deleted the string_tensor_support branch September 10, 2021 11:40

		redis> AI.TENSORSET mytensor STRING 1 2 VALUES first second
		OK

String tensor support #832

String tensor support #832

Uh oh!

Conversation

alonre24 commented Aug 22, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Aug 23, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

DvirDukhan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

DvirDukhan Aug 23, 2021

Choose a reason for hiding this comment

Uh oh!

alonre24 Aug 24, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

DvirDukhan Sep 5, 2021

Choose a reason for hiding this comment

Uh oh!

alonre24 Sep 5, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

DvirDukhan Sep 6, 2021

Choose a reason for hiding this comment

Uh oh!

alonre24 Sep 6, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alonre24 commented Aug 22, 2021 •

edited

Loading

codecov bot commented Aug 23, 2021 •

edited

Loading