Skip to content

String tensor support #832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 43 commits into from
Sep 10, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
43 commits
Select commit Hold shift + click to select a range
ed15d65
Refactor tensor set (wip)
alonre24 Aug 15, 2021
3b7d984
Support string tensor in tensor set (wip)
alonre24 Aug 16, 2021
db207d4
Refactor tensor set (wip)
alonre24 Aug 16, 2021
7651886
Refactor tensor set (wip)
alonre24 Aug 17, 2021
31568ef
Refactor tensor set (wip)
alonre24 Aug 17, 2021
e9155c8
Refactor tensor set (wip)
alonre24 Aug 18, 2021
6cbe718
Refactor tensor set (wip)
alonre24 Aug 18, 2021
aa23ccc
Refactor tensor set (wip)
alonre24 Aug 18, 2021
7de9e54
Refactor tensor set (wip)
alonre24 Aug 19, 2021
7bdc2f7
Refactor tensor set (wip)
alonre24 Aug 19, 2021
606812d
Refactor tensor set (wip)
alonre24 Aug 21, 2021
db5d30a
Refactor tensor set (wip)
alonre24 Aug 21, 2021
0b94d62
Refactor tensor set (wip)
alonre24 Aug 22, 2021
aac7798
formatting
alonre24 Aug 22, 2021
cb490d6
Merge branch 'master' into string_tensor_support
alonre24 Aug 22, 2021
07b3843
Merge branch 'master' into string_tensor_support
alonre24 Aug 22, 2021
0f77970
Merge branch 'master' into string_tensor_support
alonre24 Aug 22, 2021
0b61167
fixed bug in creating scalar tensor (with 0 dims)
alonre24 Aug 22, 2021
4893b84
Merge branch 'string_tensor_support' of https://github.com/RedisAI/Re…
alonre24 Aug 22, 2021
b504e01
all caches are the same cache now
chayim Aug 23, 2021
8940c82
PR fixes - WIP
alonre24 Aug 24, 2021
00b2f96
WIP - PR comments
alonre24 Aug 28, 2021
01dc09c
WIP - PR comments
alonre24 Aug 28, 2021
adaa680
WIP - PR comments
alonre24 Aug 29, 2021
97986c6
Merge branch 'master' into string_tensor_support
alonre24 Aug 29, 2021
c6238cd
fix rdb v4 tests + allow string values not to be null-terminated when…
alonre24 Aug 29, 2021
794bbdf
fix - set unknown blob_size to be 0.
alonre24 Aug 30, 2021
42369fd
wip
alonre24 Aug 31, 2021
db903a4
PR fixes + testing string tensor concatenation and slicing via LLAPI,…
alonre24 Sep 1, 2021
705ee47
support TF - WIP
alonre24 Sep 1, 2021
e31d1aa
support TF - WIP
alonre24 Sep 1, 2021
b8b3e19
support and test TF
alonre24 Sep 1, 2021
fbbb4e7
revert onnx model
alonre24 Sep 1, 2021
cb835ab
Document test
alonre24 Sep 1, 2021
e548cc1
upload the TF model created for testing
alonre24 Sep 1, 2021
4baceca
Merge branch 'master' into string_tensor_support
alonre24 Sep 5, 2021
1929bf6
PR fixes - WIP
alonre24 Sep 5, 2021
11c4948
PR fixes
alonre24 Sep 5, 2021
acaa815
Merge branch 'string_tensor_support' of https://github.com/RedisAI/Re…
alonre24 Sep 5, 2021
eebffc3
valgrind fixes
alonre24 Sep 5, 2021
848ef81
Add string tensor type to docs
alonre24 Sep 6, 2021
8a1d3b7
Extended TF test description
alonre24 Sep 6, 2021
2b3f391
Small refactor of RDB encode/decode (so we won't copy blob on rdb loa…
alonre24 Sep 8, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ commands:
- save_cache:
paths:
- deps
key: build-dependencies-{{ checksum "get_deps.sh" }}
key: v1-dependencies-{{ checksum "get_deps.sh" }}
- run:
name: Build
command: make -C opt all SHOW=1
Expand Down Expand Up @@ -151,7 +151,7 @@ commands:
- checkout-all
- restore_cache:
keys:
- build-dependencies-{{ checksum "get_deps.sh" }}
- v1-dependencies-{{ checksum "get_deps.sh" }}
# If no exact match is found will get dependencies from source
- setup-build-system
- run:
Expand Down Expand Up @@ -260,7 +260,7 @@ jobs:
- checkout-all
- restore_cache:
keys:
- build-dependencies-{{ checksum "get_deps.sh" }}
- v1-dependencies-{{ checksum "get_deps.sh" }}
# If no exact match is found will get dependencies from source
- setup-build-system
- run:
Expand Down Expand Up @@ -294,7 +294,7 @@ jobs:
- checkout-all
- restore_cache:
keys:
- build-dependencies-{{ checksum "get_deps.sh" }}
- v1-dependencies-{{ checksum "get_deps.sh" }}
# If no exact match is found will get dependencies from source
- setup-build-system
- run:
Expand Down
4 changes: 3 additions & 1 deletion docs/commands.md
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ AI.TENSORSET <key> <type>
_Arguments_

* **key**: the tensor's key name
* **type**: the tensor's data type can be one of: `FLOAT`, `DOUBLE`, `INT8`, `INT16`, `INT32`, `INT64`, `UINT8` or `UINT16`
* **type**: the tensor's data type can be one of: `FLOAT`, `DOUBLE`, `INT8`, `INT16`, `INT32`, `INT64`, `UINT8`, `UINT16`, `BOOL` or `STRING`
* **shape**: one or more dimensions, or the number of elements per axis, for the tensor
* **BLOB**: indicates that data is in binary format and is provided via the subsequent `data` argument
* **VALUES**: indicates that data is numeric and is provided by one or more subsequent `val` arguments
Expand All @@ -45,6 +45,8 @@ This will set the key 'mytensor' to the 2x2 RedisAI tensor:
```
redis> AI.TENSORSET mytensor FLOAT 2 2 VALUES 1 2 3 4
OK
redis> AI.TENSORSET mytensor STRING 1 2 VALUES first second
OK
Comment on lines +48 to +49
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please have a dedicated section regarding strings
how they should be provided by blob and by values.
consider doing so in a different PR involving documentation for BOOL

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, will do in a new PR

```

!!! note "Uninitialized Tensor Values"
Expand Down
1 change: 1 addition & 0 deletions src/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ ADD_LIBRARY(redisai_obj OBJECT
execution/command_parser.c
execution/parsing/deprecated.c
execution/parsing/dag_parser.c
execution/parsing/tensor_commands_parsing.c
execution/parsing/model_commands_parser.c
execution/parsing/script_commands_parser.c
execution/parsing/parse_utils.c
Expand Down
3 changes: 2 additions & 1 deletion src/backends/libtorch_c/torch_c.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ void deleter(DLManagedTensor *arg) {
}

DLManagedTensor *toManagedDLPack(const torch::Tensor &src_) {
ATenDLMTensor *atDLMTensor(new ATenDLMTensor);
auto *atDLMTensor(new ATenDLMTensor);
atDLMTensor->handle = src_;
auto &src = atDLMTensor->handle;
atDLMTensor->tensor.manager_ctx = atDLMTensor;
Expand All @@ -213,6 +213,7 @@ DLManagedTensor *toManagedDLPack(const torch::Tensor &src_) {
atDLMTensor->tensor.dl_tensor.dtype = getDLDataType(src);
atDLMTensor->tensor.dl_tensor.shape = const_cast<int64_t *>(src.sizes().data());
atDLMTensor->tensor.dl_tensor.strides = const_cast<int64_t *>(src.strides().data());
atDLMTensor->tensor.dl_tensor.elements_length = nullptr;
atDLMTensor->tensor.dl_tensor.byte_offset = 0;
return &(atDLMTensor->tensor);
}
Expand Down
Loading