Merge 'upstream/master' (1caf1d06) #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PyEval_InitThreads() and PyEval_ThreadsInitialized() functions are now deprecated and will be removed in Python 3.11. Calling PyEval_InitThreads() now does nothing. The GIL is initialized by Py_Initialize() since Python 3.7.
pybind11_add_module fails because FindPythonLibsNew.cmake try to link PythonXX.lib, but the first letter "p" should be lowercase.
* Adding pybind11::cast overload for rvalue references
* Error out eval_file * Enable dynamic attribute support for Pypy >= 6 * Add a test for dynamic attribute support * Skip test for eval_file on pypy * Workaround for __qualname__ on PyPy3 * Add a PyPy3.6 7.3.0 build * Only disable in PyPy3 * Fix travis testing * No numpy and scipy for pypy * Enable test on pypy2 * Fix logic in eval_file * Skip a few tests due to bugs in PyPy * scipy wheels are broken. make pypy2 a failrue Co-authored-by: Andreas Kloeckner <[email protected]>
* Change NAMESPACE_BEGIN and NAMESPACE_END macros into PYBIND11_NAMESPACE_BEGIN and PYBIND11_NAMESPACE_END * Fix sudden HomeBrew 'python not installed' error * Sweep difference in 'Class.__init__() must be called when overriding __init__' error message between CPython and PyPy under the rug * Homebrew updated to 3.8 yesterday. Co-authored-by: Henry Schreiner <[email protected]>
This avoids a potential conflict with names in the same scope of the same name as the embedded module, like namespaces or other global variables. Fixes pybind#2172
- `PyArray_NewFromDescr_` should have been using `Py_intptr_t const *` - https://github.com/numpy/numpy/blob/18a6e3e505ee416ddfc617f3e9afdff5a031c2c2/numpy/core/src/multiarray/ctors.h#L5-L8 - `PyArray_GetArrayParamsFromObject_` should be using `NPY_BOOL` - https://github.com/numpy/numpy/blob/18a6e3e505ee416ddfc617f3e9afdff5a031c2c2/numpy/core/src/multiarray/ctors.c#L1350-L1355 - https://docs.scipy.org/doc/numpy-1.13.0/reference/c-api.dtype.html#c.npy_bool - `PyArray_DescrNewFromType` is at offset 96 - https://github.com/numpy/numpy/blob/36e017194c32a53cf2965a513243cb3c348095df/numpy/core/code_generators/numpy_api.py#L141 - `array_t` constructor that takes a size and a pointer should take `ssize_t`. - Fixes pybind#1599
* Fix undefined memoryview format * Add missing <algorithm> header * Add workaround for py27 array compatibility * Workaround py27 memoryview behavior * Fix memoryview constructor from buffer_info * Workaround PyMemoryView_FromMemory availability in py27 * Fix up memoryview tests * Update memoryview test from buffer to check signedness * Use static factory method to create memoryview * Remove ndim arg from memoryview::frombuffer and add tests * Allow ndim=0 memoryview and documentation fixup * Use void* to align to frombuffer method signature * Add const variants of frombuffer and frommemory * Add memory view section in doc * Fix docs * Add test for null buffer * Workaround py27 nullptr behavior in test * Rename frombuffer to from_buffer
- look for windows python lib when using mingw & msys - if not found, then look for system python lib as before
…tibility. (pybind#2314) Tested with 2.7.18rc1, built with Py_UNICODE_SIZE 4. Change also tested with Python 3.8.
* add uninstall target for cmake * only add target when built as master project Co-authored-by: Henry Schreiner <[email protected]> Co-authored-by: Henry Schreiner <[email protected]>
Added a check on CMake 3.12+ to make sure the file listing is up to date. And caught a missing file with it!
There was a problem hiding this comment.
Reviewable status: 0 of 127 files reviewed, 1 unresolved discussion (waiting on @EricCousineau-TRI)
a discussion (no related file):
Working: I have no idea how to test out transitioning for GitHub actions, so meh for now.
Filed: RobotLocomotion/drake#13800
|
EDIT: Updated. |
2 tasks
…3-upstream # Conflicts: # .travis.yml # docs/advanced/classes.rst # docs/compiling.rst # include/pybind11/detail/common.h # include/pybind11/pytypes.h # tests/CMakeLists.txt # tests/test_class.cpp # tests/test_class.py # tests/test_methods_and_attributes.py # tools/pybind11Tools.cmake
EricCousineau-TRI
force-pushed
the
feature-2020-08-03-upstream
branch
from
3894160 to
cd0533e
Compare
They cause errors otherwise
EricCousineau-TRI
force-pushed
the
feature-2020-08-03-upstream
branch
from
cd0533e to
6e8628e
Compare
This was referenced Sep 6, 2020
|
Reviewer checklist:
|
EricCousineau-TRI
force-pushed
the
feature-2020-08-03-upstream
branch
from
d4e3c35 to
2211d50
Compare
There was a problem hiding this comment.
+@rpoyner-tri for review, please. Please see the reviewer checklist in this PR (no need to review the upstream code itself):
#43 (comment)
Reviewable status: 0 of 129 files reviewed, all discussions resolved (waiting on @rpoyner-tri)
a discussion (no related file):
Previously, EricCousineau-TRI (Eric Cousineau) wrote…
Working: I have no idea how to test out transitioning for GitHub actions, so meh for now.
Filed: RobotLocomotion/drake#13800
OK Done.
I just pushed a change to robotlocomotion/drake that enabled a placeholder GitHub Actions config which allows actions to run on PRs (which will have modified actions):
https://github.com/RobotLocomotion/pybind11/blob/8bc3aa1011819e61bc8a77aae2e45167bd3bff82/.github/workflows/ci.yml
rpoyner-tri
approved these changes
Sep 8, 2020
There was a problem hiding this comment.
Reviewed 122 of 127 files at r1, 7 of 7 files at r2.
Reviewable status:complete! all files reviewed, all discussions resolved
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves RobotLocomotion/drake#13800
Process:
This change is