generated from SAP/repository-template
-
Notifications
You must be signed in to change notification settings - Fork 13
fix: [Orchestration] Partial translation feature #514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rpanackal
wants to merge
27
commits into
main
Choose a base branch
from
spec-update/orchestration/fix/v2-partial-translation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix: [Orchestration] Partial translation feature #514
rpanackal
wants to merge
27
commits into
main
from
spec-update/orchestration/fix/v2-partial-translation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eaming-response-type
…onse-type # Conflicts: # orchestration/src/main/java/com/sap/ai/sdk/orchestration/DpiMasking.java
Co-authored-by: Roshin Rajan Panackal <[email protected]>
…ffix and Embedding property renaming (#469) * Introduce filtering schema changes and update generated class names - synchronous suffix removed - `createConfig` removed from `ContentFilter` - release notes updated for filtering changes * Introduce filtering schema changes and update generated class names - synchronous suffix removed - `createConfig` removed from `ContentFilter` - release notes updated for filtering changes * Release notes and jacoco coverage work around * Lower min required jacoco coverage complexity and branch rating. - Release note paraphrasing * Update e2e for input filters --------- Co-authored-by: Roshin Rajan Panackal <[email protected]>
- `ConfigToRequestTransformer` (not fixed)
…onse-type # Conflicts: # docs/release_notes.md # orchestration/pom.xml # orchestration/src/main/java/com/sap/ai/sdk/orchestration/JacksonMixins.java # sample-code/spring-app/src/test/java/com/sap/ai/sdk/app/controllers/OrchestrationTest.java
…onse-type' into spec-update/orchestration/fix/validate-v2 # Conflicts: # sample-code/spring-app/src/test/java/com/sap/ai/sdk/app/controllers/OrchestrationTest.java
…ate/orchestration/fix/validate-v2 # Conflicts: # docs/release_notes.md # orchestration/pom.xml # orchestration/src/main/java/com/sap/ai/sdk/orchestration/ContentFilter.java # orchestration/src/main/java/com/sap/ai/sdk/orchestration/OrchestrationChatCompletionDelta.java # orchestration/src/main/java/com/sap/ai/sdk/orchestration/OrchestrationChatResponse.java # orchestration/src/main/java/com/sap/ai/sdk/orchestration/OrchestrationClient.java # orchestration/src/main/java/com/sap/ai/sdk/orchestration/OrchestrationHttpExecutor.java # orchestration/src/main/java/com/sap/ai/sdk/orchestration/OrchestrationJacksonConfiguration.java # orchestration/src/main/java/com/sap/ai/sdk/orchestration/model/AzureContentSafetyInput.java # orchestration/src/main/java/com/sap/ai/sdk/orchestration/model/CompletionPostResponseStreaming.java # orchestration/src/main/java/com/sap/ai/sdk/orchestration/model/ErrorResponseStreaming.java # orchestration/src/main/java/com/sap/ai/sdk/orchestration/model/LLMModuleResult.java # orchestration/src/main/java/com/sap/ai/sdk/orchestration/spring/OrchestrationSpringChatDelta.java # orchestration/src/main/java/com/sap/ai/sdk/orchestration/spring/OrchestrationSpringChatResponse.java # orchestration/src/main/resources/spec/orchestration.yaml # orchestration/src/test/java/com/sap/ai/sdk/orchestration/OrchestrationUnitTest.java # sample-code/spring-app/src/test/java/com/sap/ai/sdk/app/controllers/OrchestrationTest.java
…ithub.com/SAP/ai-sdk-java into spec-update/orchestration/fix/validate-v2
Base automatically changed from
spec-update/orchestration/fix/validate-v2
to
main
August 7, 2025 14:03
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
AI/ai-sdk-java-backlog#301.
Orchestration has in plan a partial translation feature. Here I was integrating the changes that will come along.
Note: Until the feature is implemented as prescribed in spec here and available in canary, DO NOT MERGE.
Orchestration Spec PR: https://github.tools.sap/AI/llm-orchestration/pull/1637
Feature scope:
OrchestrationModuleConfig
now hasSAPDocumentTranslationInput
andSAPDocumentTranslationOutput
for configuring input and output translation, replacingSAPDocumentTranslation
.withInputTranslationConfig
andwithOutputTranslationConfig
.Definition of Done
Aligned changes with the JavaScript SDK