chore: Reduce constructor visibility in OpenAI / SpringAI PR #531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
rpanackal
reviewed
Aug 12, 2025
...ation-models/openai/src/main/java/com/sap/ai/sdk/foundationmodels/openai/OpenAiToolCall.java
Outdated
Show resolved
Hide resolved
… into chatcompletion-for-springopenai2
n-o-u-r-h-a-n
added a commit
that referenced
this pull request
Aug 19, 2025
* first draft * Align with docs * Codestyle * feat: [OpenAI] Spring AI integration * test * test * Fixing errors in OpenAiChatOptions according to "Upgrade to Spring AI 1.0.0 (GA Version) (#503)" * Fixing errors in OpenAiChatOptions according to "Upgrade to Spring AI 1.0.0 (GA Version) (#503)" * Fixing SpringAiAgenticWorkflowService according to "Upgrade to Spring AI 1.0.0 (GA Version) (#503)". * Implementation of completion and streamChatCompletion in SpringAiOpenAiService + their corresponding passed tests in SpringAiOpenAiTest class. Regarding the OpenAiChatModel class it was just formatting, nothing changed. * Removing a comment * Removing a comment * Chat Memory test working. * Formatting for SpringAiOpenAiService. * Removing unneccessary imports in SpringAiOpenAiService. * Updating the toOpenAiRequest in OpenAiChatModel.java. * Implementing the new approach --> 4 methods in OpenAiChatCompletionRequest.java return only this now and other constructors other than main are removed for now. * Editing the approach. * Fix compilation and format and annotations and javadoc * Remove unrelated code * implementation hint * Formatting * Updating OpenAiChatOptions.java with our Config Object. * Formatting * Passing our Config Object as an input parameter for OpenAiChatOptions() * Fixing NullPointerException in toOpenAiRequest method for ToolCallng Test to pass. * Adding topK for the Config Class ?? * Formatting * Update foundation-models/openai/src/main/java/com/sap/ai/sdk/foundationmodels/openai/spring/OpenAiChatModel.java Co-authored-by: Alexander Dümont <[email protected]> * Failing Test of testToolCallingWithoutExecution() in SpringAiOpenAiTest.java * Resolving Reviewed Issues. * Resolving Reviewed Issues. * --> still having testToolCallingWithoutExecution() in SpringAiOpenAiTest.java failing. --> still fix of null of message.getText() in toAssistantMessage() method in OpenAiChatModel.java pending. * format * format * Removing wild cards imports * Sucessful build of OpenAi * Sucessful build of Spring Boot app. * Formatting * Removing this test for now. * Fix nullcheck * Fix unit test * chore: Reduce constructor visibility in OpenAI / SpringAI PR (#531) * Reduce constructors * Update thresholds * Update javadoc and factory name * Replacing config.toolsExecutable with getter-usage + adding tolerate to withStop() method. * 2 * Assistant message wiht tools calls * unit test * Creating OpenAiChatModelTest.java and updating the controller and index page. * Formatting * formatting * Finishing the tests * Added more options and metadata * Formatting * Fixing Format/Style (Minor). * Fixing Format/Style (Minor). * Updating the Release notes according to integrating SpringAI with our OpenAi Client. * Update docs/release_notes.md Co-authored-by: Charles Dubois <[email protected]> * Handling JsonProcessingException * Handling JsonProcessingException * Handling JsonProcessingException * Formatting * protected extractOptions --------- Co-authored-by: Jonas Israel <[email protected]> Co-authored-by: Jonas-Isr <[email protected]> Co-authored-by: I538344 <[email protected]> Co-authored-by: Alexander Dümont <[email protected]> Co-authored-by: SAP Cloud SDK Bot <[email protected]> Co-authored-by: Alexander Dümont <[email protected]> Co-authored-by: Roshin Rajan Panackal <[email protected]> Co-authored-by: Charles Dubois <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Constructors shall not be made public in #526
To allow for dedicated questions / suggestions, in case this comes up.