Long runtime in Y_TEST_CODE_DETECTOR class

[ThomasErgin]

Check Name

This issues applies the Test-Code-Detector-Class Y_TEST_CODE_DETECTOR which - I recon - is executed for every check.

Actual Behavior

Recently I scheduled a Code Pal check run on the report ZABAPGIT_STANDALONE, which is part of the open source project ABAPGIT and is a behemoth of ABAP (> 100.00 code lines!!!). I already expected that checking this report might take a while. But actually I found that check run to fail because of a too long runtime.

Strangly, during the execution I noticed, that a vast amount of runtime is spent on the test-code-detector, which - I guess - is intended to identify ABAPunit test classes. I performed a SAT trace on the Code Pal and found, that >95% of runtime is lost inside of Y_TEST_CODE_DETECTOR.
When checking the Call Stack I found, that in method Y_CHECK_BOOLEAN_INPUT_PARAM->EXECUTE_CHECK( ) a LOOP on all the class statements is carried out.
Later in the callstack I found, that in method Y_TEST_CODE_DETECTOR->DETERMINE_TEST_CODE the same LOOP on all class statements is repeated.
Both LOOPs combined will lead to a quadratic number of execution of the underlying process_tokens( )-method and - for this behemoth of ABAP - will lead to an unrealistic high runtime.

Without fully understanding the motivation of the developer, it appears to be wrong, that the process_tokens( )-method is called <number_of_class_statements>^2 times.

You can replicate this issue by schedule a check run on the ABAPGit-Standalone class. I suppose, that other bigger ABAPs will also be affected.

Expected Behavior

The runtime for bigger option of ABAP gets acceptable.

[lucasborin]

[lucasborin]

@ThomasKempfle: Solution available under branch 1.16.0. Feel free to pull and test it. By the way, it depends on SAP Note 2527903.