Skip to content

Cannot run unit tests on 752 #461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
pokrakam opened this issue Sep 16, 2021 · 9 comments · Fixed by #463
Closed

Cannot run unit tests on 752 #461

pokrakam opened this issue Sep 16, 2021 · 9 comments · Fixed by #463
Assignees
Labels
bug Something isn't working correctly

Comments

@pokrakam
Copy link
Contributor

💡 Code pal for ABAP follows the Clean ABAP. If the issue relates to coding style, please submit it here.

Actual Behavior
Trying to unit test Code Pal, every unit tests dumps on my 752 NPL Developer system
image
Not sure if this is specific to my system or 752, I cannot investigate this as it really screws up my system such that I cannot open CL_CI_SCAN after it happened and cannot log on until the system is restarted. Several "Server resources exhausted" messages in the system log. Perhaps someone can test this on another 752 system to see whether it's NPL or 752 in general?

Expected Behavior
Unit tests run.

@pokrakam pokrakam added the bug Something isn't working correctly label Sep 16, 2021
@lucasborin
Copy link
Member

Hm, that is strange. Can you please get the values of these two tables?

  • levels
  • tokens

@pokrakam
Copy link
Contributor Author

Here they are:

Row  DEPTH  LEVEL  STMNT  FROM  TO  NAME                         TYPE
=====================================================================
1    1      0      0      1     6   CODE_PAL_FOR_ABAP_UNIT_TEST  P


Row  LEVEL  STRUC  FROM  TO  NUMBER  COLONROW  TROW  COLONCOL  TCOL  PREFIXLEN  TYPE  TERMINATOR  ENHMT
=======================================================================================================
1    1      1      1     2   1       0         1     0         16    0          K     .           0
2    1      2      3     3   2       0         2     0         19    0          K     .           0
3    1      3      4     6   3       0         3     0         18    0          C     .           0
4    1      4      7     14  4       0         5     0         17    0          K     .           0
5    1      5      15    17  5       0         6     0         14    0          C     .           0
6    1      4      18    18  6       0         7     0         8     0          K     .           0

I think I may have found a clue in the debugger, this is where it all goes off the rails:
image

image

Since the ABAP Unit runner keeps going it crashes here for each test and just kills the whole system.

@lucasborin
Copy link
Member

lucasborin commented Sep 16, 2021

Workaround: Can you please set this parameter to abap_false?

image

In parallel, I am looking for a 7.52 here.

@pokrakam
Copy link
Contributor Author

No joy, P_NO_CLASSIFICATION doesn't exist on 752. I note this is handled specifically straight after the piece of code you gave:

    CATCH SYSTEM-EXCEPTIONS dyn_call_meth_param_not_found = 1.
      CREATE OBJECT result TYPE (class_type) PARAMETER-TABLE parameters.
    ENDCATCH.

    IF sy-subrc = 1.
      DELETE parameters WHERE name = 'P_NO_CLASSIFICATION'.
      CREATE OBJECT result TYPE (class_type) PARAMETER-TABLE parameters.
    ENDIF.
  ENDMETHOD.

It's low priority, mostly curious whether it was my system or 752 in general. I can always use my A4H if need be.

@lucasborin
Copy link
Member

lucasborin commented Sep 16, 2021

I found a 7.52 here (ERY), and yeah, the bug is there. Let me debug it. :)

@lucasborin
Copy link
Member

Ps: 7.57 and 7.40 are both working fine.

@lucasborin lucasborin self-assigned this Sep 16, 2021
@lucasborin
Copy link
Member

@pokrakam: In the Y_REF_SCAN_MANAGER_DOUBLE, please change the CREATE_TRDIR to:

  METHOD create_trdir.
    SELECT SINGLE * FROM trdir INTO @result WHERE name = 'Y_REF_SCAN_MANAGER_DOUBLE=====CP'.
  ENDMETHOD.

It will solve the issue.

@pokrakam
Copy link
Contributor Author

Yep, works, thanks!

lucasborin pushed a commit that referenced this issue Sep 17, 2021
@lucasborin lucasborin linked a pull request Sep 17, 2021 that will close this issue
lucasborin added a commit that referenced this issue Sep 17, 2021
* fix #461

* changelog

Co-authored-by: Lucas Borin <[email protected]>
@lucasborin
Copy link
Member

Fix available under branch 1.16.0.

lucasborin pushed a commit that referenced this issue Sep 17, 2021
lucasborin added a commit that referenced this issue Sep 23, 2021
* saving progress

* saving progress

* Update changelog.txt

* global class vs local class

* local vs global test class

* Global Test Class fix

* enabling unit test

* refactoring y_check_function uts

* abaplint feedback

* abaplint feedback

* removing unecessary fields and fixing checksum

* fixing coverages (statement)

* default noaunit for test

* fixing bug in chain declaration

* fixing unit test

* Less than 3 newlines and at least a single newline are required in between metho

* ref #461

* solving conflict

* Update changelog.txt

* Update src/foundation/y_code_pal_ref_scan_double.clas.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Update src/foundation/y_code_pal_ref_scan_double.clas.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* fixing collect dump

* fixing pseudo comment dump and performance issue

* reusing refscan (performance)

* Update src/checks/y_check_pseudo_comment_usage.clas.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Update src/checks/y_check_pseudo_comment_usage.clas.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Update src/checks/y_check_pseudo_comment_usage.clas.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Update src/checks/y_check_pseudo_comment_usage.clas.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* pseudo comment refactoring (performance)

* collect (performance)

* Update changelog.txt

* Reorder definitions to top of routine

* pseudo_comment_usage ignore_pseudo

* more performance improvements

* removing deprecated methods

Co-authored-by: Lucas Borin <[email protected]>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
lucasborin added a commit that referenced this issue Oct 7, 2021
* saving progress

* saving progress

* Update changelog.txt

* global class vs local class

* local vs global test class

* Global Test Class fix

* enabling unit test

* refactoring y_check_function uts

* abaplint feedback

* abaplint feedback

* removing unecessary fields and fixing checksum

* fixing coverages (statement)

* default noaunit for test

* fixing bug in chain declaration

* fixing unit test

* Less than 3 newlines and at least a single newline are required in between metho

* ref #461

* solving conflict

* Update changelog.txt

* Update src/foundation/y_code_pal_ref_scan_double.clas.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Update src/foundation/y_code_pal_ref_scan_double.clas.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* fixing collect dump

* fixing pseudo comment dump and performance issue

* reusing refscan (performance)

* Update src/checks/y_check_pseudo_comment_usage.clas.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Update src/checks/y_check_pseudo_comment_usage.clas.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Update src/checks/y_check_pseudo_comment_usage.clas.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Update src/checks/y_check_pseudo_comment_usage.clas.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* pseudo comment refactoring (performance)

* collect (performance)

* Update changelog.txt

* Reorder definitions to top of routine

* pseudo_comment_usage ignore_pseudo

* more performance improvements

* removing deprecated methods

* activating prefer_inline (#465)

* activating prefer_inline

* Prefer Inline Declarations, PERCENTAGE

* Prefer Inline Declarations, RISK_LVL

* Prefer Inline Declarations, HAS_REDIRECTION

* Prefer Inline Declarations, TITLE

* Prefer Inline Declarations, CLASS_SEARCH_STRING

Co-authored-by: Lucas Borin <[email protected]>

* performance improvement (check statement pos)

* Prefer Inline Declarations, PROFILE_CONFIGURATIONS

* Line break multiple parameters

* Reorder definitions to top of routine

* Update changelog.txt

* magic number

* adding pseudo comments

* Adding pseudo comment

* Fixing magic number

* Use | to assemble text!

* Use | to assemble text!

* Prefer RETURNING to EXPORTING!

* Prefer LINE_EXISTS or LINE_INDEX to READ TABLE or LOOP AT!

* Prefer IS NOT to NOT IS!

* replacing pseudo

* removing unecessary pseudos

* unecessary pseudo

* clean coding f4call

* new SAP note dependency

Co-authored-by: Lucas Borin <[email protected]>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
@lucasborin lucasborin mentioned this issue Nov 1, 2021
lucasborin added a commit that referenced this issue Nov 1, 2021
2021-11-01 v.1.16.0
------------------
* Prefer New: Dynamic Call with Parameters (#502)
* DB Access in UT: Global Inheritance (#500)
* DB Access in UT: Local Inheritance (#498)
* Skip 'Prefer RETURNING to EXPORTING' when both exist (#490)
* Pseudo Comment Usage: Multiple Inline Entries (#494)
* Prefer Pragmas to Pseudo Comments: Multiple Pseudo Comments (#489)
* Y_CHECK_MESSAGE_EASY_TO_FIND dump (#492)
* Chain Declaration for Complex Structures (#488)
* Empty Catch Alternative Pseudo Comment (#337)
+ Alternative Pseudo Comment (#486)
* line_exists does not support the operator IN (#484)
* Empty Catch: Test Double Framework (#483)
* Y_CHECK_FORM: Screen Events (#454)
* Magic Number: CASE SY-TABIX and CO NUMBERS (#480)
* Magic Number: Leading Zeros (#479)
* Prefer New to Create Object: Dynamic Type (#469)
* Magic Number: Table Index (#468)
* Use native *_wa variables (#474)
* Refactoring (#436,#452,#458)
* Cannot run unit tests on 752 (#461)
* Profiles: Allow Exemptions (#447)
* BAdI example class vs Percentage Comment (#443)
* Unit-Test Assert Validator (#450)
+ Prefer Pragmas to Pseudo Comments (#421)
+ COLLECT restriction (#441)
* RAP needs CREATE OBJECT ... FOR TESTING (#444)
* Filter functional operands in "Unit Test Assert" check (#460)
ghost pushed a commit that referenced this issue Nov 17, 2021
* 1.16.0

* enabling changelog

* RAP needs CREATE OBJECT ... FOR TESTING (#448)

* resolves #444

* changelog

* COLLECT restrictions (#442)

* new check

* abapLint

* supporting programs

* closing gaps

* adding documentation

* Adding Changelog

* exempt ddic typed table

* supporting ddic table type

* supporting header line

* removing gap section

* supporting class attributes

* Use functional writing style for method calls

* Adding example

* Prefer Pragmas to Pseudo Comments (#446)

* new check

* new check

* documentation

* exempting SLIN

* Adding example

* Unit-Test Assert Validator (#450)

* Unit-Test Assert Validator 

resolve #449

* changelog

* BAdI example class vs Percentage Comment (#451)

* BAdI example class vs Percentage Comment

resolve #443

* changelog

* Allow Exemptions (#453)

* big refactoring

* isolating unit tests

* changelog

* forcing commit

* forcing commit

* Handle functional operand in assert check (#462)

* Functional operand check

* Fix unit test and nesting syntax

* Lint

* Update exemption unit test

* Fix unit test

* Add functional operand fix #460 to changelog

* removing static test, and adding more test cases

Co-authored-by: Lucas Borin <[email protected]>

* Unit Test on 752 (#463)

* fix #461

* changelog

Co-authored-by: Lucas Borin <[email protected]>

* Refactoring Code Pal (#457)

* saving progress

* saving progress

* Update changelog.txt

* global class vs local class

* local vs global test class

* Global Test Class fix

* enabling unit test

* refactoring y_check_function uts

* abaplint feedback

* abaplint feedback

* removing unecessary fields and fixing checksum

* fixing coverages (statement)

* default noaunit for test

* fixing bug in chain declaration

* fixing unit test

* Less than 3 newlines and at least a single newline are required in between metho

* ref #461

* solving conflict

* Update changelog.txt

* Update src/foundation/y_code_pal_ref_scan_double.clas.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Update src/foundation/y_code_pal_ref_scan_double.clas.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* fixing collect dump

* fixing pseudo comment dump and performance issue

* reusing refscan (performance)

* Update src/checks/y_check_pseudo_comment_usage.clas.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Update src/checks/y_check_pseudo_comment_usage.clas.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Update src/checks/y_check_pseudo_comment_usage.clas.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Update src/checks/y_check_pseudo_comment_usage.clas.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* pseudo comment refactoring (performance)

* collect (performance)

* Update changelog.txt

* Reorder definitions to top of routine

* pseudo_comment_usage ignore_pseudo

* more performance improvements

* removing deprecated methods

* activating prefer_inline (#465)

* activating prefer_inline

* Prefer Inline Declarations, PERCENTAGE

* Prefer Inline Declarations, RISK_LVL

* Prefer Inline Declarations, HAS_REDIRECTION

* Prefer Inline Declarations, TITLE

* Prefer Inline Declarations, CLASS_SEARCH_STRING

Co-authored-by: Lucas Borin <[email protected]>

* performance improvement (check statement pos)

* Prefer Inline Declarations, PROFILE_CONFIGURATIONS

* Line break multiple parameters

* Reorder definitions to top of routine

* Update changelog.txt

* magic number

* adding pseudo comments

* Adding pseudo comment

* Fixing magic number

* Use | to assemble text!

* Use | to assemble text!

* Prefer RETURNING to EXPORTING!

* Prefer LINE_EXISTS or LINE_INDEX to READ TABLE or LOOP AT!

* Prefer IS NOT to NOT IS!

* replacing pseudo

* removing unecessary pseudos

* unecessary pseudo

* clean coding f4call

* new SAP note dependency

Co-authored-by: Lucas Borin <[email protected]>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* use native *_wa variables (#475)

* resolves #474

* changelog

* forcing commit

* restore

Co-authored-by: Lucas Borin <[email protected]>

* disabling abaplint check_syntax

* Magic Number: Table Index  (#477)

* resolves #474

* fix #475

* fixing case

* changelog

Co-authored-by: Lucas Borin <[email protected]>

* Prefer New to Create Object: Dynamic Type (#478)

* Fixes #469

* changelog

Co-authored-by: Lucas Borin <[email protected]>

* Magic Number: Leading Zeros (#479)

* fixing magic number for leading zeros

* changelog

Co-authored-by: Lucas Borin <[email protected]>

* Magic Number: CASE SY-TABIX and CO NUMBERS (#480)

* case sy-tabix and Co numbers

* changelog

Co-authored-by: Lucas Borin <[email protected]>

* Y_CHECK_FORM: Screen Events (#482)

* Fixes #454

* changelog

Co-authored-by: Lucas Borin <[email protected]>

* Empty Catch: Test Double Framework (#483)

* Fixes #332

* Missing space between string or character literal and parentheses

* changelog

Co-authored-by: Lucas Borin <[email protected]>

* line_exists does not support the operator IN (#485)

* Fixes #484

* changelog

Co-authored-by: Lucas Borin <[email protected]>

* Alternative Pseudo Comment (#486)

* saving progress

* saving progress

* saving progress

* alternative pseudo

* fixing 7.40 compatibility

* 7.40 compatibility

* revert checksum

* adjusting pseudo comment usage

* adding unit tests

* Missing space between string or character literal and parentheses

* new pseudo comment

* changelog

* alt_pcom in ut

* Update empty_catch.md

Co-authored-by: Lucas Borin <[email protected]>

* Chain Declaration for Complex Structures (#488)

* new test scope

* fixes #466

* cleaning self-reference

* cleaning chain declaration

* cleaning chain declaration

* cleaning chain declaration

* fixing syntax error

* changelog

* documentation

Co-authored-by: Lucas Borin <[email protected]>

* fixing syntax error

* `Y_CHECK_MESSAGE_EASY_TO_FIND` dump (#492)

* fixes #491

* changelog

Co-authored-by: Lucas Borin <[email protected]>

* short review (#493)

Co-authored-by: Lucas Borin <[email protected]>

* Prefer Pragmas to Pseudo Comments (#495)

* fixes #489

* changelog

Co-authored-by: Lucas Borin <[email protected]>

* Pseudo Comment Usage: Multiple Inline Entries (#496)

* fixes #494

* changelog

Co-authored-by: Lucas Borin <[email protected]>

* Skip `Prefer RETURNING to EXPORTING` when both exist (#497)

* fixes #490

* changelog

Co-authored-by: Lucas Borin <[email protected]>

* DB Access in UT: Local Inheritance (#498)

* partially solves #433

* changelog

* renaming variable

Co-authored-by: Lucas Borin <[email protected]>

* DB Access in UT: Global Inheritance (#500)

* fixes #433

* changelog

Co-authored-by: Lucas Borin <[email protected]>

* fixing short dump (#501)

Co-authored-by: Lucas Borin <[email protected]>

* removing unecessary pseudo comment

* Prefer New: Dynamic Call with Parameters (#503)

* fixes #502

* changelog

Co-authored-by: Lucas Borin <[email protected]>

* mass change of check data

* Update changelog.txt

* UI finetuning

* minor change

* abaplint compliance

* abaplint picky compliance

* UI Changes

* Revert "UI Changes"

This reverts commit cac373d.

* UI Changes

* small UI adjustments

* Update changelog.txt

Co-authored-by: Lucas Borin <[email protected]>
Co-authored-by: Mike Pokraka <[email protected]>
Co-authored-by: Lucas Borin <[email protected]>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
ghost pushed a commit that referenced this issue Feb 8, 2022
* new version

* Quickfix: Pseudo Comment (#509)

* adding quickfixes

* Less than 3 newlines and at least a single newline are required in between metho

* changelog

Co-authored-by: Lucas Borin <[email protected]>

* fixing (#515)

Co-authored-by: Lucas Borin <[email protected]>

* abapgit 1.112.0

* remove unused variable (#522)

Co-authored-by: Eugen Günther <[email protected]>

* mass change of check data (#507)

* 1.16.0

* enabling changelog

* RAP needs CREATE OBJECT ... FOR TESTING (#448)

* resolves #444

* changelog

* COLLECT restrictions (#442)

* new check

* abapLint

* supporting programs

* closing gaps

* adding documentation

* Adding Changelog

* exempt ddic typed table

* supporting ddic table type

* supporting header line

* removing gap section

* supporting class attributes

* Use functional writing style for method calls

* Adding example

* Prefer Pragmas to Pseudo Comments (#446)

* new check

* new check

* documentation

* exempting SLIN

* Adding example

* Unit-Test Assert Validator (#450)

* Unit-Test Assert Validator 

resolve #449

* changelog

* BAdI example class vs Percentage Comment (#451)

* BAdI example class vs Percentage Comment

resolve #443

* changelog

* Allow Exemptions (#453)

* big refactoring

* isolating unit tests

* changelog

* forcing commit

* forcing commit

* Handle functional operand in assert check (#462)

* Functional operand check

* Fix unit test and nesting syntax

* Lint

* Update exemption unit test

* Fix unit test

* Add functional operand fix #460 to changelog

* removing static test, and adding more test cases

Co-authored-by: Lucas Borin <[email protected]>

* Unit Test on 752 (#463)

* fix #461

* changelog

Co-authored-by: Lucas Borin <[email protected]>

* Refactoring Code Pal (#457)

* saving progress

* saving progress

* Update changelog.txt

* global class vs local class

* local vs global test class

* Global Test Class fix

* enabling unit test

* refactoring y_check_function uts

* abaplint feedback

* abaplint feedback

* removing unecessary fields and fixing checksum

* fixing coverages (statement)

* default noaunit for test

* fixing bug in chain declaration

* fixing unit test

* Less than 3 newlines and at least a single newline are required in between metho

* ref #461

* solving conflict

* Update changelog.txt

* Update src/foundation/y_code_pal_ref_scan_double.clas.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Update src/foundation/y_code_pal_ref_scan_double.clas.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* fixing collect dump

* fixing pseudo comment dump and performance issue

* reusing refscan (performance)

* Update src/checks/y_check_pseudo_comment_usage.clas.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Update src/checks/y_check_pseudo_comment_usage.clas.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Update src/checks/y_check_pseudo_comment_usage.clas.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Update src/checks/y_check_pseudo_comment_usage.clas.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* pseudo comment refactoring (performance)

* collect (performance)

* Update changelog.txt

* Reorder definitions to top of routine

* pseudo_comment_usage ignore_pseudo

* more performance improvements

* removing deprecated methods

* activating prefer_inline (#465)

* activating prefer_inline

* Prefer Inline Declarations, PERCENTAGE

* Prefer Inline Declarations, RISK_LVL

* Prefer Inline Declarations, HAS_REDIRECTION

* Prefer Inline Declarations, TITLE

* Prefer Inline Declarations, CLASS_SEARCH_STRING

Co-authored-by: Lucas Borin <[email protected]>

* performance improvement (check statement pos)

* Prefer Inline Declarations, PROFILE_CONFIGURATIONS

* Line break multiple parameters

* Reorder definitions to top of routine

* Update changelog.txt

* magic number

* adding pseudo comments

* Adding pseudo comment

* Fixing magic number

* Use | to assemble text!

* Use | to assemble text!

* Prefer RETURNING to EXPORTING!

* Prefer LINE_EXISTS or LINE_INDEX to READ TABLE or LOOP AT!

* Prefer IS NOT to NOT IS!

* replacing pseudo

* removing unecessary pseudos

* unecessary pseudo

* clean coding f4call

* new SAP note dependency

Co-authored-by: Lucas Borin <[email protected]>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* use native *_wa variables (#475)

* resolves #474

* changelog

* forcing commit

* restore

Co-authored-by: Lucas Borin <[email protected]>

* disabling abaplint check_syntax

* Magic Number: Table Index  (#477)

* resolves #474

* fix #475

* fixing case

* changelog

Co-authored-by: Lucas Borin <[email protected]>

* Prefer New to Create Object: Dynamic Type (#478)

* Fixes #469

* changelog

Co-authored-by: Lucas Borin <[email protected]>

* Magic Number: Leading Zeros (#479)

* fixing magic number for leading zeros

* changelog

Co-authored-by: Lucas Borin <[email protected]>

* Magic Number: CASE SY-TABIX and CO NUMBERS (#480)

* case sy-tabix and Co numbers

* changelog

Co-authored-by: Lucas Borin <[email protected]>

* Y_CHECK_FORM: Screen Events (#482)

* Fixes #454

* changelog

Co-authored-by: Lucas Borin <[email protected]>

* Empty Catch: Test Double Framework (#483)

* Fixes #332

* Missing space between string or character literal and parentheses

* changelog

Co-authored-by: Lucas Borin <[email protected]>

* line_exists does not support the operator IN (#485)

* Fixes #484

* changelog

Co-authored-by: Lucas Borin <[email protected]>

* Alternative Pseudo Comment (#486)

* saving progress

* saving progress

* saving progress

* alternative pseudo

* fixing 7.40 compatibility

* 7.40 compatibility

* revert checksum

* adjusting pseudo comment usage

* adding unit tests

* Missing space between string or character literal and parentheses

* new pseudo comment

* changelog

* alt_pcom in ut

* Update empty_catch.md

Co-authored-by: Lucas Borin <[email protected]>

* Chain Declaration for Complex Structures (#488)

* new test scope

* fixes #466

* cleaning self-reference

* cleaning chain declaration

* cleaning chain declaration

* cleaning chain declaration

* fixing syntax error

* changelog

* documentation

Co-authored-by: Lucas Borin <[email protected]>

* fixing syntax error

* `Y_CHECK_MESSAGE_EASY_TO_FIND` dump (#492)

* fixes #491

* changelog

Co-authored-by: Lucas Borin <[email protected]>

* short review (#493)

Co-authored-by: Lucas Borin <[email protected]>

* Prefer Pragmas to Pseudo Comments (#495)

* fixes #489

* changelog

Co-authored-by: Lucas Borin <[email protected]>

* Pseudo Comment Usage: Multiple Inline Entries (#496)

* fixes #494

* changelog

Co-authored-by: Lucas Borin <[email protected]>

* Skip `Prefer RETURNING to EXPORTING` when both exist (#497)

* fixes #490

* changelog

Co-authored-by: Lucas Borin <[email protected]>

* DB Access in UT: Local Inheritance (#498)

* partially solves #433

* changelog

* renaming variable

Co-authored-by: Lucas Borin <[email protected]>

* DB Access in UT: Global Inheritance (#500)

* fixes #433

* changelog

Co-authored-by: Lucas Borin <[email protected]>

* fixing short dump (#501)

Co-authored-by: Lucas Borin <[email protected]>

* removing unecessary pseudo comment

* Prefer New: Dynamic Call with Parameters (#503)

* fixes #502

* changelog

Co-authored-by: Lucas Borin <[email protected]>

* mass change of check data

* Update changelog.txt

* UI finetuning

* minor change

* abaplint compliance

* abaplint picky compliance

* UI Changes

* Revert "UI Changes"

This reverts commit cac373d.

* UI Changes

* small UI adjustments

* Update changelog.txt

Co-authored-by: Lucas Borin <[email protected]>
Co-authored-by: Mike Pokraka <[email protected]>
Co-authored-by: Lucas Borin <[email protected]>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Refactoring Quick Fixes (#523)

* quickfixes are now mandatory

* first check + message

* no quickfix

* wip

* implementing abstract method

* pseudo comments won't enable the quickfix

* removing unnecessary :

* removing duplicated quick fix

* changelog

Co-authored-by: Lucas Borin <[email protected]>
Co-authored-by: Eugen Günther <[email protected]>

* Replace class by interface in check documentation (#543)

* Update test-seam-usage.md

* Update db-access-in-ut.md

* Update external-call-in-ut.md

* Update unit_test_assert.md

* Replace class by interface

In the check "Constants Interface Check", the documentation of the exception referred to class definition instead of interface definition.

* Update db-access-in-ut.md

* Update external-call-in-ut.md

* Update test-seam-usage.md

* Update test-seam-usage.md

* Update unit_test_assert.md

* Update unit_test_assert.md

* Update unit_test_assert.md

Co-authored-by: estevao-schultz-neto-SAP <[email protected]>
Co-authored-by: Eugen Günther <[email protected]>

* Update changelog.txt

* Update changelog.txt

Co-authored-by: Lucas Borin <[email protected]>
Co-authored-by: Lars Hvam <[email protected]>
Co-authored-by: Eugen Günther <[email protected]>
Co-authored-by: Mike Pokraka <[email protected]>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Co-authored-by: Michael Schneider <[email protected]>
Co-authored-by: estevao-schultz-neto-SAP <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working correctly
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants