New abapLint Rules

abaplint.json

@@ -12,230 +12,153 @@
       "url": "https://github.com/abaplint/deps",
       "folder": "/deps1",
       "files": "/src/**/*.*"
-    },
-    {
-      "url": "https://github.com/abapGit/abapGit",
-      "folder": "/deps2",
-      "files": "/src/**/*.*"
     }
   ],
   "syntax": {
     "version": "v740sp08",
-    "errorNamespace": "^(Z|Y|LCL_|TY_|LIF_)",
+    "errorNamespace": "^(Y)",
     "globalConstants": ["cntb_btype_button", "scan_struc_stmnt_type", "scan_stmnt_type", "scan_struc_type", "scan_token_type"],
     "globalMacros": []
   },
   "rules": {
     "7bit_ascii": true,
     "abapdoc": false,
     "allowed_object_naming": true,
-    "allowed_object_types": {
-      "exclude": [],
-      "severity": "Error",
-      "allowed": []
-    },
+    "allowed_object_types": false,
     "ambiguous_statement": false,
-    "avoid_use": {
-      "exclude": [],
-      "severity": "Error",
-      "define": true,
-      "endselect": true,
-      "execSQL": true,
-      "kernelCall": true,
-      "communication": true,
-      "statics": true,
-      "systemCall": true,
-      "defaultKey": false,
-      "break": false,
-      "describeLines": false
-    },
+    "avoid_use": false,
     "begin_end_names": true,
     "begin_single_include": true,
-    "call_transaction_authority_check": true,
-    "chain_mainly_declarations": {
-      "exclude": [],
-      "severity": "Error",
-      "definitions": true,
-      "write": true,
-      "move": true,
-      "refresh": true,
-      "unassign": true,
-      "clear": true,
-      "hide": true,
-      "free": true,
-      "include": true,
-      "check": true
-    },
+    "call_transaction_authority_check": false,
+    "chain_mainly_declarations": true,
     "check_abstract": true,
     "check_comments": false,
-    "check_ddic": true,
+    "check_ddic": false,
     "check_include": true,
     "check_no_handler_pragma": true,
     "check_subrc": false,
     "check_syntax": true,
     "check_text_elements": false,
-    "check_transformation_exists": true,
+    "check_transformation_exists": false,
     "class_attribute_names": false,
     "cloud_types": true,
     "colon_missing_space": true,
-    "commented_code": false,
+    "commented_code": true,
     "constructor_visibility_public": true,
     "contains_tab": false,
-    "cyclomatic_complexity": {
-      "exclude": [],
-      "severity": "Error",
-      "max": 20
-    },
-    "definitions_top": false,
+    "cyclomatic_complexity": true,
+    "dangerous_statement": true,
+    "db_operation_in_loop": false,
+    "definitions_top": true,
     "description_empty": true,
-    "double_space": false,
+    "double_space": {
+      "startParen": false
+    },
     "downport": true,
     "empty_line_in_statement": false,
     "empty_statement": true,
-    "empty_structure": false,
+    "empty_structure": true,
     "exit_or_check": false,
-    "exporting": false,
-    "forbidden_identifier": {
-      "exclude": [],
-      "severity": "Error",
-      "check": []
-    },
-    "forbidden_pseudo_and_pragma": {
-      "exclude": [],
-      "severity": "Error",
-      "pseudo": [],
-      "pragmas": [],
-      "ignoreGlobalClassDefinition": false,
-      "ignoreGlobalInterface": false
-    },
-    "forbidden_void_type": {
-      "exclude": [],
-      "severity": "Error",
-      "check": []
-    },
+    "exporting": true,
+    "forbidden_identifier": false,
+    "forbidden_pseudo_and_pragma": false,
+    "forbidden_void_type": false,
     "form_tables_obsolete": true,
-    "fully_type_constants": {
-      "exclude": [],
-      "severity": "Error",
-      "checkData": true
-    },
+    "fully_type_constants": false,
     "function_module_recommendations": true,
-    "functional_writing": {
-      "exclude": [],
-      "severity": "Error",
-      "ignoreExceptions": true
-    },
+    "functional_writing": true,
     "global_class": true,
     "identical_conditions": true,
     "identical_contents": true,
     "identical_form_names": true,
+    "identical_descriptions": false,
     "if_in_if": true,
     "implement_methods": true,
     "in_statement_indentation": false,
     "indentation": false,
     "inline_data_old_versions": true,
-    "keep_single_parameter_on_one_line": false,
-    "keyword_case": false,
-    "line_break_multiple_parameters": false,
+    "intf_referencing_clas": {
+      "severity": "Warning"
+    },
+    "keep_single_parameter_on_one_line": true,
+    "line_break_multiple_parameters": true,
     "line_break_style": true,
     "line_length": false,
     "line_only_punc": false,
     "local_class_naming": false,
     "local_testclass_location": true,
     "local_variable_names": false,
     "main_file_contents": true,
-    "many_parenthesis": false,
+    "many_parenthesis": true,
+    "max_one_method_parameter_per_line": true,
+    "method_implemented_twice": true,
     "max_one_statement": true,
     "message_exists": true,
     "method_length": false,
-    "method_overwrites_builtin": false,
+    "method_overwrites_builtin": true,
     "method_parameter_names": false,
-    "mix_returning": false,
+    "mix_returning": true,
+    "modify_only_own_db_tables": false,
     "msag_consistency": true,
-    "nesting": false,
+    "nesting": true,
     "names_no_dash": true,
-    "newline_between_methods": {
-      "exclude": [],
-      "severity": "Error",
-      "count": 3,
-      "logic": "less"
-    },
+    "newline_between_methods": true,
     "no_public_attributes": false,
+    "no_yoda_conditions": false,
     "object_naming": false,
-    "obsolete_statement": {
-      "exclude": [],
-      "severity": "Error",
-      "refresh": true,
-      "compute": true,
-      "add": false,
-      "subtract": false,
-      "multiply": true,
-      "move": true,
-      "divide": true,
-      "requested": true,
-      "occurs": true,
-      "setExtended": true,
-      "withHeaderLine": true,
-      "fieldSymbolStructure": true,
-      "typePools": true,
-      "load": true
-    },
-    "omit_parameter_name": false,
+    "obsolete_statement": true,
+    "omit_parameter_name": true,
     "omit_receiving": true,
+    "parser_702_chaining": false,
     "parser_error": true,
     "parser_missing_space": true,
     "prefer_inline": false,
-    "prefer_is_not": false,
+    "prefer_is_not": true,
+    "prefer_raise_exception_new": true,
     "prefer_returning_to_exporting": true,
     "prefer_xsdbool": true,
-    "preferred_compare_operator": false,
-    "prefix_is_current_class": false,
+    "preferred_compare_operator": true,
+    "prefix_is_current_class": true,
     "reduce_string_templates": true,
     "release_idoc": true,
     "remove_descriptions": false,
-    "rfc_error_handling": false,
-    "selection_screen_naming": {
-      "exclude": [],
-      "severity": "Error",
-      "patternKind": "required",
-      "ignoreNames": [],
-      "ignorePatterns": [],
-      "parameter": "^P_.+$",
-      "selectOption": "^S_.+$"
-    },
-    "sequential_blank": false,
-    "short_case": {
-      "exclude": [],
-      "severity": "Error",
-      "length": 1,
-      "allow": []
+    "rfc_error_handling": true,
+    "select_add_order_by": false,
+    "select_performance": {
+      "severity": "Warning"
     },
+    "selection_screen_naming": false,
+    "sequential_blank": true,
+    "short_case": true,
     "sicf_consistency": true,
     "space_before_colon": true,
-    "space_before_dot": {
-      "exclude": [],
-      "severity": "Error",
-      "ignoreGlobalDefinition": true,
-      "ignoreExceptions": true
+    "space_before_dot": true,
+    "sql_escape_host_variables": {
+      "severity": "Warning"
     },
-    "sql_escape_host_variables": false,
-    "start_at_tab": false,
+    "start_at_tab": true,
     "superclass_final": true,
     "sy_modification": true,
     "tabl_enhancement_category": true,
     "try_without_catch": true,
     "type_form_parameters": true,
     "types_naming": false,
+    "uncaught_exception": false,
     "unknown_types": true,
     "unreachable_code": true,
-    "unused_methods": false,
+    "unsecure_fae": false,
+    "unused_methods": true,
     "unused_types": true,
-    "unused_variables": false,
+    "unused_variables": {
+      "severity": "Warning"
+    },
     "use_bool_expression": true,
-    "use_line_exists": false,
+    "use_class_based_exceptions": true,
+    "use_line_exists": true,
     "use_new": true,
     "when_others_last": true,
     "whitespace_end": true,
-    "xml_consistency": true
+    "xml_consistency": true,
+    "keyword_case": false
   }
 }

src/categories/y_category_code_pal.clas.abap

@@ -22,7 +22,7 @@ CLASS Y_CATEGORY_CODE_PAL IMPLEMENTATION.
 
   METHOD constructor.
     super->constructor( ).
-    description = get_class_description(  ).
+    description = get_class_description( ).
     category    = 'CL_CI_CATEGORY_TOP'.
     position    = '001'.
   ENDMETHOD.

src/checks/y_check_check_stmnt_position.clas.abap

@@ -59,15 +59,15 @@ CLASS y_check_check_stmnt_position IMPLEMENTATION.
 
 
   METHOD is_not_relevant_token.
-    result = xsdbool(    token EQ 'METHOD'
-                      OR token EQ 'FORM'
-                      OR token EQ 'FUNCTION'
-                      OR token EQ 'MODULE'
-                      OR token EQ 'DATA'
-                      OR token EQ 'TYPES'
-                      OR token EQ 'CHECK'
-                      OR token EQ 'FIELD-SYMBOLS'
-                      OR token EQ 'CONSTANTS' ).
+    result = xsdbool(    token = 'METHOD'
+                      OR token = 'FORM'
+                      OR token = 'FUNCTION'
+                      OR token = 'MODULE'
+                      OR token = 'DATA'
+                      OR token = 'TYPES'
+                      OR token = 'CHECK'
+                      OR token = 'FIELD-SYMBOLS'
+                      OR token = 'CONSTANTS' ).
   ENDMETHOD.
 
 

src/checks/y_check_comment_position.clas.abap

@@ -9,9 +9,6 @@ CLASS y_check_comment_position DEFINITION PUBLIC INHERITING FROM y_check_base CR
     METHODS has_wrong_position IMPORTING statement TYPE sstmnt
                                RETURNING VALUE(result) TYPE abap_bool.
 
-    METHODS get_first_character IMPORTING token TYPE stokesx
-                                RETURNING VALUE(result) TYPE char1.
-
     METHODS is_pseudo_comment IMPORTING token TYPE stokesx
                               RETURNING VALUE(result) TYPE abap_bool.
 
@@ -102,15 +99,6 @@ CLASS Y_CHECK_COMMENT_POSITION IMPLEMENTATION.
   ENDMETHOD.
 
 
-  METHOD get_first_character.
-    TRY.
-        result = token-str(1).
-      CATCH cx_sy_range_out_of_bounds.
-        CLEAR result.
-    ENDTRY.
-  ENDMETHOD.
-
-
   METHOD is_pseudo_comment.
     TRY.
         result = xsdbool( token-str(4) = '"#EC' ).