Skip to content

New abapLint Rules #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 76 commits into from
Apr 8, 2021
Merged

New abapLint Rules #304

merged 76 commits into from
Apr 8, 2021

Conversation

lucasborin
Copy link
Member

No description provided.

@lucasborin lucasborin requested a review from a team as a code owner January 12, 2021 12:41
ghost
ghost previously approved these changes Jan 13, 2021
View reviewed changes
@ghost
Copy link

ghost commented Jan 13, 2021 •
edited by ghost
Loading

whats with abaplint?
45 issues just about the upper/lower case -.-

@larshp
Copy link
Contributor

larshp commented Jan 13, 2021

it needs additional configuration, or alternatively the findings to be fixed

https://rules.abaplint.org/keyword_case/

I also opened abaplint/abaplint#1671 yesterday

Base automatically changed from 1.11.0 to master January 18, 2021 20:17
@lucasborin lucasborin dismissed ghost ’s stale review January 18, 2021 20:17

The base branch was changed.

ghost
ghost previously approved these changes Jan 19, 2021
View reviewed changes
@larshp
Copy link
Contributor

larshp commented Jan 28, 2021

Hi,
I've looked through the 45 findings, and personally, I think they should be fixed.

But as noted in https://github.com/SAP/styleguides/blob/master/clean-abap/CleanABAP.md#use-your-pretty-printer-team-settings, its important that your team decides which style to go for. But looking at the current code its mainly upper case keywords.

@lucasborin lucasborin changed the base branch from master to 1.14.0 April 5, 2021 17:55
@lucasborin lucasborin requested a review from a user April 6, 2021 17:17
@lucasborin
Copy link
Member Author

Checks reviewed. Let's take a look at the reported issues now.

@lucasborin lucasborin changed the title Update abaplint.json New abapLint Rules Apr 6, 2021
@lucasborin lucasborin marked this pull request as draft April 6, 2021 17:18
@lucasborin
Copy link
Member Author

A few checks set to warning as they are reporting false positives. Please, check abapLint issues for further information.

lucasborin
lucasborin commented Apr 7, 2021
View reviewed changes
Copy link
Member Author

@lucasborin lucasborin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review done.

@lucasborin lucasborin marked this pull request as ready for review April 7, 2021 18:56
@lucasborin
Copy link
Member Author

@eugen-guenther-sap : Would you like to review the changed objects?
@larshp : These 9 issues reported by abaplint are false positives (reported in abapLint issues)

ghost
ghost previously approved these changes Apr 8, 2021
View reviewed changes
@larshp
Copy link
Contributor

larshp commented Apr 8, 2021

Try again, 2.73.8 published

Also note there are a few warnings in the configuration file,
image

@larshp
Copy link
Contributor

larshp commented Apr 8, 2021

🥳 🍾

@lucasborin lucasborin merged commit 732f8b5 into 1.14.0 Apr 8, 2021
@lucasborin lucasborin deleted the abaplint_keyword_case branch April 8, 2021 14:37
lucasborin added a commit that referenced this pull request Apr 23, 2021
@lucasborin @estevao-schultz-neto-SAP @abaplint
1.14.0 (#345)
e45ffb4 
* 1.14.0

* fixing version

* adding missing checks feature (#346)

* adding missing checks feature

* minor update

Co-authored-by: Eugen Guenther <[email protected]>

* Update changelog.txt

* Standard Functions in Prefer IS NOT to NOT IS (#353)

* solves #338

* Update changelog.txt

* contains_any_not_of and contains_any_of

* Prefer New to Create Object (#354)

* implements #283

* Update check_documentation.md

* minor fixes

* Create prefer-new-to-create-object.md

* Update changelog.txt

* Update prefer-new-to-create-object.md

* adding example

Co-authored-by: estevao-schultz-neto-SAP <[email protected]>

* Unit Test Assert Check (#347)

* new check

* fixing class description

* adding demo

* comparing token type

* Update check_documentation.md

* Update check_documentation.md

* Create unit_test_assert.md

* Update changelog.txt

* Update unit_test_assert.md

Co-authored-by: estevao-schultz-neto-SAP <[email protected]>

* Update y_check_unit_test_assert.clas.abap

* Update y_check_unit_test_assert.clas.abap

* Part 1 - core feature - allow pseudo comment exception #329 (#357)

* feature - allow pseudo comment exception

* Update y_check_unit_test_assert.clas.abap

Co-authored-by: Lucas Borin <[email protected]>

* Revert "Part 1 - core feature - allow pseudo comment exception #329 (#357)" (#358)

This reverts commit 4da128b.

* fixes #359 (#366)

* Update changelog.txt

* New abapLint Rules (#304)

* Update abaplint.json

* Update abaplint.json

* Update abaplint.json

* Update abaplint.json

* disabling empty_line_in_statement

* Remove double space

* disabling exit_or_check

* disabling line_only_punc

Reporting false-positives:
abaplint/abaplint#1888

* Update abaplint.json

* Update abaplint.json

* Compare operator "EQ" not preferred

* Disabling no_yoda_conditions

abaplint/abaplint#1891

* Method "get_first_character" not used

* Compare operator "EQ" not preferred

* Keep single parameter on one line

* Statement "ADD" is obsolete

* Compare operator "GE" not preferred

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Compare operator "GE" not preferred

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Compare operator "EQ" not preferred

* Avoid use of SELECT *

* Uncaught exception cx_sy_itab_line_not_found

* Compare operator "EQ", "LT, "GT" not preferred

* Reorder definitions to top of routine

* Too many parenthesis, simple

* Prefer Inline Declarations, CHECK_CONFIGURATION

* Missing space between string or character literal

* wrongly commited object

* Some fixes

Compare operator "EQ" not preferred
Prefer Inline Declarations, FM_NAME
Reorder definitions to top of routine

* Statement "ADD" is obsolete

* Compare operator "EQ" not preferred

* Some fixes

Compare operator "EQ" not preferred
Statement "ADD" is obsolete
Statement "SUBTRACT" is obsolete
Line break multiple parameters

* Some fixes

Compare operator "EQ" not preferred
Method "check_token_content" not used
Statement "ADD" is obsolete

* Some fixes

Line break multiple parameters
Compare operator "GE" not preferred
Compare operator "EQ" not preferred

* ops, fixing bug

* Compare operator "EQ" not preferred

* Statement "ADD" is obsolete

* Some fixes

Statement "ADD" is obsolete
Statement "SUBTRACT" is obsolete
Too many parenthesis, complex

* Some fixes

Omit default parameter name "FIRST_TOKEN"
Statement "SUBTRACT" is obsolete
Statement "ADD" is obsolete

* several fixes

* Update y_check_unit_test_assert.clas.abap

* Update abaplint.json

* Update abaplint.json

* Update abaplint.json

* Several fixes

* several fixes

* SEVERAL FIXES

* Update abaplint.json

* Update abaplint.json

* several fixes

* Update abaplint.json

* Update abaplint.json

* Update abaplint.json

* Update abaplint.json

* a few fixes

* Update abaplint.json

* several fixes

* Update abaplint.json

* several fixes

* Update abaplint.json

* a few fixes

* Update abaplint.json

* Update y_exemption_general.clas.abap

* Update y_test_code_detector.clas.abap

* Update y_check_empty_catches.clas.abap

* Don't mix RETURNING and EXPORTING/CHANGING paramet

* Update abaplint.json

* Update abaplint.json

* Update abaplint.json

Co-authored-by: Eugen Günther <[email protected]>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Update changelog.txt

* Update y_check_base.clas.abap

* Update src/foundation/y_check_base.clas.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Update unit_test_assert.md

* Feature allow pseudo comment exception (#361)

* feature - allow pseudo comment exception

* Update y_check_unit_test_assert.clas.abap

* update

* minor update

* requested changes

* Update src/profiles/y_profile_admin_classes.prog.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* UX update

* abaplint fix

* Update y_check_base.clas.abap

* Update y_profile_admin_classes.prog.abap

* Update y_profile_manager.clas.abap

* Update src/profiles/y_profile_admin_classes.prog.abap

Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Update y_profile_administrator.prog.xml

* Update y_profile_admin_classes.prog.abap

* Update y_profile_admin_classes.prog.abap

* minor change

* abaplint fix

* Update y_check_base.clas.abap

* update

* update

* Update y_profile_admin_classes.prog.abap

* update

* Update how-to-configure.md

* Update how-to-configure.md

* Update how-to-configure.md

* Update changelog.txt

Co-authored-by: Eugen Guenther <[email protected]>
Co-authored-by: Eugen Günther <[email protected]>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>

* Prefer LINE_EXISTS or LINE_INDEX to READ TABLE or LOOP AT (#355)

* implements #286

* Update changelog.txt

* Update check_documentation.md

* demo + description

* Create prefer-line-exists.md

* Update y_check_unit_test_assert.clas.abap

* fixing from/to

* Update y_check_prefer_line_exists.clas.testclasses.abap

Co-authored-by: Eugen Günther <[email protected]>

* Update changelog.txt

* Update abaplint.json (#377)

* adjust of ignore pseudocomment on relevant checks (#375)

* adjust of ignore pseudocomment on relevant checks

* update

* update

Co-authored-by: Lucas Borin <[email protected]>

* changing default severity (#376)

* changing default severity

* fixing version

* c_note

* Update README.md

* Update README.md

* Update how-to-configure.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update README.md

* Update how-to-configure.md

* Update how-to-configure.md

* Update how-to-configure.md

* Update how-to-configure.md

* Update how-to-configure.md

* Update changelog.txt

* Update README.md

* Update how-to-configure.md

* Update how-to-configure.md

* Update how-to-configure.md

* Update how-to-configure.md

* Update how-to-configure.md

Co-authored-by: estevao-schultz-neto-SAP <[email protected]>

* Update changelog.txt

* Update changelog.txt

* Update changelog.txt

* fixing broken ut

Co-authored-by: Eugen Guenther <[email protected]>
Co-authored-by: estevao-schultz-neto-SAP <[email protected]>
Co-authored-by: Eugen Günther <[email protected]>
Co-authored-by: abaplint[bot] <24845621+abaplint[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucasborin @larshp