Lock graphql config dep #32
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Started seeing CLI failures related to a node engine failure for version 18, similar to what I fixed in #30.
The latest version of Minimatch (10) now requires node 20 or higher.
This doesn't work for us because we need CLI to run under node 18.
We can see using
npm why
that we're getting this through graphql-configThe minimatch dependency was bumped in graphql-config in 5.1.4, so we're locking it back down to 5.1.3.
Additionally, since this is the second time we've run into an issue like this, I've gone ahead and swapped all our package version to use specific versions. I used the versions that ended up in the
package-lock.json
after a successfulnpm install
.