Skip to content

downgrade graphql-config #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 28, 2025
Merged

downgrade graphql-config #35

merged 1 commit into from
Apr 28, 2025

Conversation

lopert
Copy link
Contributor

@lopert lopert commented Apr 28, 2025

graphql-config needs to be at 5.1.3, because 5.1.4 is not compatible with node 18, which we need to support in the CLI.

I previously attempted to lock us to 5.1.3 but dependabot opened a PR anyways. See my PR for the full context.

I tested npm install in a JS function that depends on the current main (aka with 5.1.4) and got the same error.

> npm install                                                  ✔ 
npm error code EBADENGINE
npm error engine Unsupported engine
npm error engine Not compatible with your version of node/npm: [email protected]
npm error notsup Not compatible with your version of node/npm: [email protected]
npm error notsup Required: {"node":"20 || >=22"}
npm error notsup Actual:   {"npm":"10.8.2","node":"v18.20.8"}

Next steps

  • Hopefully dependabot attempt to re-upgrade this again, and I can mark this dependency as ignored.
  • I'll create an issue in this repo for adding a node 18 test to CI to catch future bumps that may break node 18.

@lopert lopert requested a review from saga-dasgupta April 28, 2025 14:30
Copy link
Contributor

@saga-dasgupta saga-dasgupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops! I'm sorry for merging that dependabot PR!

@lopert
Copy link
Contributor Author

lopert commented Apr 28, 2025

@saga-dasgupta don't worry about it! nothing in the repo shows that we need node 18 compatibility which is the real issue 🙈

@lopert lopert merged commit 5993311 into main Apr 28, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants