Add archived sorters and change rt-sort to rtsort #4077
Conversation
|
I think this is a great idea! Help makes it clear what we actively still support and what we don't! |
| # archived | ||
| # klusta="klusta", | ||
| # yass="yass", | ||
| # tridesclous="tridesclous" |
There was a problem hiding this comment.
Are we not doing tridesclous here anymore? I saw you had a commit un-archiving it?
There was a problem hiding this comment.
@samuelgarcia made a new release :)
|
@alejoe91 https://spikeinterface.readthedocs.io/en/latest/references.html I guess the reference could be hyphenated if that is how they refer to their own sorter? So our wrapper is unhyphenated and theirs is? |
| @@ -43,14 +43,14 @@ | |||
| combinato="combinato", | |||
| herdingspikes="herdingspikes", | |||
| kilosort4="kilosort4", | |||
| klusta="klusta", | |||
| mountainsort4="mountainsort4", | |||
| mountainsort5="mountainsort5", | |||
| pykilosort="pykilosort", | |||
There was a problem hiding this comment.
pykilosort is only for < 3.10. I guess we are not there yet, but we are very close to needing to archive this. We should remember this.
https://github.com/MouseLand/pykilosort/blob/master/pyks2.yml
There was a problem hiding this comment.
I think we should change this to rtsort since that is what the wrapper will have, and then leave the citation alone since the actual name of the sorter is RT-Sort. OR we leave the sorter as RT-Sort since that is the name in the citation. But I think we need to change this one line of the refs now that I've read everything.
Good catch!!! done in last commti :) |
No description provided.