-
-
Notifications
You must be signed in to change notification settings - Fork 28
Merge 2.0.0 into master #211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pty-masks Fix #52 Comparisons with empty masks
…hread Show errors outside main thread
…-errors-outside-main-thread
…hread Fixes Toufool#86 Stop uncaught exceptions from silently crashing the app
…on't allow a start image to load if hotkeys are not set.
Configured VSCode and Markdownlint settings Added and configured the following linters as strict as I could: pylint, flake8, mypy, bandit, pyright Partially filled in some type stubs: cv2, imagehash, keyboard, pyautogui, pythonwin, win32helper [Breaking change] Using interpolation=cv2.INTER_NEAREST everywhere as it is the fastest interlpolation method Hide generated/compiled files SelectRegionWidget width and height as functions Added validate_images_before_parsing() to validate images both before maxFPS and starting autosplitter
First linting pass
…-'Check-For-Updates-On-Open'-immediatly
…-Open'-immediatly Async check for updates + Save 'check for updates on open' immediately
Configured Building and linting workflow
Pylint + Flake8 linting
Merge dev to 2.0.0
* Updated configs * Updated typings * Updated some code * Fix #47 * Revert mypy stuff
* More consistent formatting and types - Added autofixes to the lint script. - Added a quotes autofixer using `unify` - Added a trailing comma checker and autofixer - Applied trailing commas - Ordered requirements alphabetically - Ensure the last version of D3DShot is used (0.1.5, not 0.1.3) - Remove configuration for unused linters (black/prettier/sonarlint) - Updated types from typeshed * Updated virtual camera link * Update types and pylint
* pyright update * lint-and-build cover more files * Get IDirect3dDevice from LearningModelDevice Closes Toufool#175 Co-authored-by: Algomancer <[email protected]> * Ensure we're using the right camera size And not OpenCV's default 640x480 * Fix rounding error in displayed decimal * Revert "back to windowed" This reverts commit 9553271. * Fix highest similarity for start image * Fix split below treshold when image is not valid * Detect gray frames from OBS-Camera Co-authored-by: Algomancer <[email protected]>
Especially in the case of 1080p or higher, if the non-transparent area of the mask image used for the split is small, resizing the entire image to 320x240 will lose the information inside the mask. One idea to prevent this is to adaptively determine the target size according to the number of nonzero elements in the alpha channel of the split image. At least for the L2 norm and histogram, such a change would not affect performance since they only use information about the mask's interior. Masks are not recommended with pHash anyway. Co-authored-by: zalgo3 <[email protected]>
* Point python_grabber to andreaschiavinato * Added summary of histogram * Backport changes from linux branch * Improved pyright and formatters usage * Config updates * Fix links * Disable next/previous while delaying * proper `is_running` variable * Fix loading and clearing of start image * Rename "already_running" to "already_open" * Fix delay intervals * Add support for start image pause time * Default to MediaCapture's d3d * Re-enable buttons after delay * Beta 1 (feature-freeze, bugfixes only)
* Option to build without build number * Fix repo url from workflow build * Resize mask with image * Pin more dependencies, Speed-up installs and update comments * Add mypy config for optional support.
Also fixed run_start_time not accounting for the delay in parsing images
…pture Device (Toufool#198) Fix issue with programatically setting capture_device_combobox index
* Fix start issue after finishing splits - `self.is_running = False` at the end of `__auto_splitter` - Revert moving initialization of some values - Move `self.run_start_time = time()` before parsing images * Update hardcoded references to repo name
* Update docs, comments and typings Add link to dev builds bump beta version Update flake8 checks "fix" typing issue caused by PyQt6 incorrect callable * Slight build improvement
* Fix D3DDD issue on hybrid gpu laptops 1. Some Desktop Duplication setup was done in advance, even if that method won't be used 2. Hybrid GPU laptops can have issues with D3D Desktop Duplication. The issue and a workaround is now documented * Fixed some blocking typing and linting issues
@Avasam I believe this is accurate, but let me know if it's not
Toufool
approved these changes
Apr 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets do it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All changes since 1.6.1:
.pkl
) format won't be compatible. (Closes Overhaul settings #70)<
and>
buttons when in a Delayed state #183, Closes Feature Request: Previous/Next Image #130)...
while runningPause
Time onstart_auto_splitter
image does not work #182)Windows Graphics Capture API
(thanks @Algomancer forIDirect3dDevice
LearningModelDevice
fallback),D3D Desktop Duplication
andCapture Device
(webcams and capture cards, including OBS virtual camera) as capture methods.Read https://github.com/Toufool/AutoSplit#capture-device for more details. (Closes Dolphin not detected as a hardware window #110, Closes create Direct3D11CaptureFramePool failed #147, Closes obs 28.0 update causing window projector to not be capturable #160, Closes Easy IDirect3DDevice Fix #175, Closes obs 28.0 update causing window projector to not be capturable #160)
types-*
, but they didn't need an update).