fix: Restarting UnityTransport after it failed to start [MTT-3452] #2220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdmazom
approved these changes
Sep 27, 2022
jakobbbb
pushed a commit
to GooseGirlGames/com.unity.netcode.gameobjects
that referenced
this pull request
Feb 22, 2023
…nity-Technologies#2220) * Add test for transport restart failure * Fix restart after transport failure * Add CHANGELOG entry * Add PR number to CHANGELOG entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1924. The issue was that we shut down the transport when it failed to be started, which disposed of the network settings. So when restarting the transport, there would be errors when configuring the settings. The fix was to not shut down when failing to start. The start process only ends up creating the network driver, so to revert to the state before we started, we just need to dispose of the driver.
Changelog
UnityTransportwould fail to restart after a first failure (even if what caused the initial failure was addressed).Testing and Documentation