Skip to content

fix: NetworkManager property more robust on NetworkBehaviour #2257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 19, 2022
Merged

fix: NetworkManager property more robust on NetworkBehaviour #2257

merged 3 commits into from
Oct 19, 2022

Conversation

jeffreyrainy
Copy link
Contributor

@jeffreyrainy jeffreyrainy commented Oct 14, 2022 •
edited
Loading

Makes the NetworkManager property more robust by checking

  • NetworkObject being null
  • Its NetworkManager being null
  • GetComponentInParent throwing an exception on null objects
  • returning NetworkManager.Singleton if all else fails

Addresses https://jira.unity3d.com/browse/MTT-3376

@jeffreyrainy jeffreyrainy marked this pull request as ready for review October 18, 2022 18:39
@jeffreyrainy jeffreyrainy requested a review from a team as a code owner October 18, 2022 18:39
@jeffreyrainy jeffreyrainy merged commit 30d23bc into develop Oct 19, 2022
@jeffreyrainy jeffreyrainy deleted the fix/mtt-3376/load-event-complete-shutdown branch October 19, 2022 18:54
jakobbbb pushed a commit to GooseGirlGames/com.unity.netcode.gameobjects that referenced this pull request Feb 22, 2023
@jeffreyrainy @jakobbbb
fix: NetworkManager property more robust on NetworkBehaviour (Unity-T…
cb28716 
…echnologies#2257)

fix: more robust checks around NetworkObjects being null
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NoelStephensUnity NoelStephensUnity NoelStephensUnity approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeffreyrainy @NoelStephensUnity