fix: client not tracking changes to layer weights [MTT-7166] #2674
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShadauxCat
approved these changes
Aug 23, 2023
ShadauxCat
reviewed
Aug 23, 2023
|
|
||
| ### Fixed | ||
|
|
||
| - Fixed "writing past the end of the buffer" error when calling ResetDirty() on managed network variables that are larger than 256 bytes when serialized. | ||
| - Fixed issue where `NetworkAnimator` was not internally tracking changes to layer weights which prevented proper layer weight synchronization back to the original layer weight value. (#2674) | ||
| - Fixed "writing past the end of the buffer" error when calling ResetDirty() on managed network variables that are larger than 256 bytes when serialized. (#2670) |
There was a problem hiding this comment.
thanks for catching this omission
NoelStephensUnity
deleted the
fix/client-not-tracking-changes-to-layer-weights-mtt-7166
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves the issue where clients were not applying layer weight changes to their internal layer weight table which prevented clients from detecting layer weight changes back to the original layer weight values.
MTT-7166
fix: #2663
Changelog
NetworkAnimatorwas not internally tracking changes to layer weights which prevented proper layer weight synchronization back to the original layer weight value.Testing and Documentation
NetworkAnimatorTests.