Skip to content

fix: truncate when reverting writes during NetworkBehaviour synchronize #2749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 31, 2023

Conversation

NoelStephensUnity
Copy link
Collaborator

@NoelStephensUnity NoelStephensUnity commented Oct 23, 2023

This fixes an issue where a NetworkBehaviour would add an additional 6 bytes to its serialization data if nothing was written during the synchronize call.

MTT-7719

Changelog

  • Fixed: Issue where NetworkBehaviour.Synchronize was not truncating the write buffer if nothing was serialized during NetworkBehaviour.OnSynchronize causing an additional 6 bytes to be written per NetworkBehaviour component instance.

Testing and Documentation

  • No tests have been added.
  • No documentation changes or additions were necessary.

truncate buffer back to the position.
adding comment
adding change log entry
@NoelStephensUnity NoelStephensUnity marked this pull request as ready for review October 23, 2023 20:44
@NoelStephensUnity NoelStephensUnity requested a review from a team as a code owner October 23, 2023 20:44
@NoelStephensUnity NoelStephensUnity enabled auto-merge (squash) October 23, 2023 20:55
@NoelStephensUnity NoelStephensUnity merged commit b309cc3 into develop Oct 31, 2023
@NoelStephensUnity NoelStephensUnity deleted the fix/truncate-when-reverting-writes branch October 31, 2023 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants