Skip to content

fix: truncate when reverting writes during NetworkBehaviour synchronize #2749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 31, 2023
Merged

fix: truncate when reverting writes during NetworkBehaviour synchronize #2749

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
65cedde
fix
NoelStephensUnity Oct 23, 2023
ff4a6de
style
NoelStephensUnity Oct 23, 2023
087f65c
update
NoelStephensUnity Oct 23, 2023
c579122
Merge branch 'develop' into fix/truncate-when-reverting-writes
NoelStephensUnity Oct 26, 2023
950cfa7
Merge branch 'develop' into fix/truncate-when-reverting-writes
NoelStephensUnity Oct 27, 2023
f1de22a
Merge branch 'develop' into fix/truncate-when-reverting-writes
NoelStephensUnity Oct 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions com.unity.netcode.gameobjects/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,14 @@ Additional documentation and release notes are available at [Multiplayer Documen

## [Unreleased]

### Added

### Fixed

- Fixed a bug where having a class with Rpcs that inherits from a class without Rpcs that inherits from NetworkVariable would cause a compile error. (#2751)
- Fixed issue where `NetworkBehaviour.Synchronize` was not truncating the write buffer if nothing was serialized during `NetworkBehaviour.OnSynchronize` causing an additional 6 bytes to be written per `NetworkBehaviour` component instance. (#2749)

### Changed

## [1.7.0] - 2023-10-11

Expand Down
2 changes: 2 additions & 0 deletions com.unity.netcode.gameobjects/Runtime/Core/NetworkBehaviour.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -993,6 +993,8 @@ internal bool Synchronize<T>(ref BufferSerializer<T> serializer, ulong targetCli
if (finalPosition == positionBeforeSynchronize || threwException)
{
writer.Seek(positionBeforeWrite);
// Truncate back to the size before
writer.Truncate();
return false;
}
else
Expand Down