Skip to content

Conversation

NoelStephensUnity
Copy link
Collaborator

@NoelStephensUnity NoelStephensUnity commented May 28, 2025

This PR resolves an issue where a NetworkBehaviour with multiple NetworkVariables could drop changes if one of the NetworkVariables has unique NetworkVariableUpdateTraits set, is dirty, but is not ready to send.

Based on user @khyperia's submission #3462.

Changelog

  • Fixed: issue where NetworkVariables on a NetworkBehaviour could fail to synchronize changes if one has NetworkVariableUpdateTraits set and is dirty but is not ready to send.

Testing and Documentation

  • Includes integration test NetworkVariableTraitsTests.WhenNonTraitsIsDirtyButTraitsIsNotReadyToSend.
  • No documentation changes or additions were necessary.

Backport

This required and up-port to v2.x (#3466)

@NoelStephensUnity NoelStephensUnity added the port:2.x-needed This issue needs to be ported to 2.X branch label May 28, 2025
Adding test to verify this fix.
Adjusting changelog entry.
Adding XML API to avoid PVP error.
@NoelStephensUnity NoelStephensUnity changed the title fix: NetworkVariables sometimes drop changes fix: NetworkVariables with NetworkVariableUpdateTraits can cause other NetworkVariables to drop changes May 28, 2025
One more area that needed adjusting to avoid PVP error.
@NoelStephensUnity NoelStephensUnity marked this pull request as ready for review May 28, 2025 19:03
@NoelStephensUnity NoelStephensUnity requested a review from a team as a code owner May 28, 2025 19:03
@NoelStephensUnity NoelStephensUnity enabled auto-merge (squash) May 28, 2025 20:19
@NoelStephensUnity NoelStephensUnity added port:2.x-completed This issue was ported to 2.X branch and removed port:2.x-needed This issue needs to be ported to 2.X branch labels May 28, 2025
@NoelStephensUnity NoelStephensUnity merged commit ea046c5 into develop May 28, 2025
41 checks passed
@NoelStephensUnity NoelStephensUnity deleted the fix/netvar-dropping-changes-khyperia branch May 28, 2025 21:25
NoelStephensUnity added a commit that referenced this pull request May 29, 2025
…r NetworkVariables to drop changes (up-port) (#3466)

This PR resolves an issue where a `NetworkBehaviour` with multiple
`NetworkVariables` could drop changes if one of the `NetworkVariables`
has unique `NetworkVariableUpdateTraits` set, is dirty, but is not ready
to send.

Based on user @khyperia's submission #3462.

## Changelog

- Fixed: issue where `NetworkVariable`s on a `NetworkBehaviour` could
fail to synchronize changes if one has `NetworkVariableUpdateTraits` set
and is dirty but is not ready to send.

## Testing and Documentation

- Includes integration test
`NetworkVariableTraitsTests.WhenNonTraitsIsDirtyButTraitsIsNotReadyToSend`.
- No documentation changes or additions were necessary.

## Backport

This is an up-port of #3465

---------

Co-authored-by: khyperia <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
port:2.x-completed This issue was ported to 2.X branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants