fix: DontDestroyWithOwner v2.4.2 client-server regression #3522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating the NetworkObjectDontDestroyWithOwnerTests to also test for when the DontDestroyWithOwner is not set and making the test compatible with the CI CMB service testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves the Forum-1658887 discovered client-server specific issue in the v2.4.2 release where spawned objects with the default
NetworkObject.DontDestroyWithOwnersetting (disabled/false) would not be despawned and destroyed when the owning client disconnected.MTTB-1396
Changelog
NetworkObject.DontDestroyWithOwnerset tofalsewould not be destroyed when using a client-server network topology.Testing and Documentation
NetworkObjectDontDestroyWithOwnerTestsintegration test.Backport
This is specific to NGO v2.4.2 release.