fix: connection approval cannot exceed mtu size #3564
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoelStephensUnity
changed the title
NoelStephensUnity
added
the
port:1.x-completed
EmandM
approved these changes
Jul 30, 2025
EmandM
pushed a commit
that referenced
this pull request
Jul 30, 2025
) This PR resolves the issue where a NetworkConfig.ConnectionData that caused the ConnectionRequestMessage to exceed the transport's MTU size would result in a buffer overflow error by updating ConnectionRequestMessage to use the ReliableFragmentedSequenced pipeline as opposed to the ReliableSequenced pipeline. [MTTB-1467](https://jira.unity3d.com/browse/MTTB-1467) ## Changelog - Fixed: issue where NetworkConfig.ConnectionData could cause the ConnectionRequestMessage to exceed the transport's MTU size and would result in a buffer overflow error. ## Testing and Documentation - Includes modifications to `ConnectionApproval` integration tests to use a > MTU size `NetworkConfig.ConnectionData`. - No documentation changes or additions were necessary. ## Backport This is a back port of #3564.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves the issue where a
NetworkConfig.ConnectionDatathat caused theConnectionRequestMessageto exceed the transport's MTU size would result in a buffer overflow error by updatingConnectionRequestMessageto use theReliableFragmentedSequencedpipeline as opposed to theReliableSequencedpipeline.MTTB-1467
Changelog
Testing and Documentation
ConnectionApprovalTestsintegration tests to use a > MTU sizeNetworkConfig.ConnectionData.Backport
This needs to be back ported to the v1.x branch.