Skip to content

fix: connection approval cannot exceed mtu size #3564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 30, 2025
Merged

fix: connection approval cannot exceed mtu size #3564

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
32b0fed
fix
NoelStephensUnity Jul 28, 2025
e2fb66c
test
NoelStephensUnity Jul 28, 2025
8fd8d59
update
NoelStephensUnity Jul 28, 2025
d3ea320
Merge branch 'develop-2.0.0' into fix/connection-approval-cannot-exce…
EmandM Jul 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions com.unity.netcode.gameobjects/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ Additional documentation and release notes are available at [Multiplayer Documen

### Fixed

- Fixed issue where NetworkConfig.ConnectionData could cause the ConnectionRequestMessage to exceed the transport's MTU size and would result in a buffer overflow error. (#3564)
- Fixed regression issue in v2.x where `NetworkObject.GetNetworkBehaviourAtOrderIndex` was converted from public to internal. (#3541)
- Fixed ensuring OnValueChanged callback is still triggered on the authority when a collection changes and then reverts to the previous value in the same frame. (#3539)
- Fixed synchronizing the destroyGameObject parameter to clients for InScenePlaced network objects. (#3514)
Expand Down
2 changes: 1 addition & 1 deletion com.unity.netcode.gameobjects/Runtime/Connection/NetworkConnectionManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -635,7 +635,7 @@ private void SendConnectionRequest()
}
}

SendMessage(ref message, NetworkDelivery.ReliableSequenced, NetworkManager.ServerClientId);
SendMessage(ref message, NetworkDelivery.ReliableFragmentedSequenced, NetworkManager.ServerClientId);
message.MessageVersions.Dispose();
}

Expand Down
14 changes: 9 additions & 5 deletions com.unity.netcode.gameobjects/Tests/Runtime/ConnectionApproval.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ public enum PlayerCreation
Prefab,
PrefabHash,
NoPlayer,
FailValidation
FailValidation,
}
private PlayerCreation m_PlayerCreation;
private bool m_ClientDisconnectReasonValidated;
Expand All @@ -38,7 +38,7 @@ public ConnectionApprovalTests(PlayerCreation playerCreation)

protected override int NumberOfClients => 1;

private Guid m_ValidationToken;
private string m_ValidationToken;

protected override bool ShouldCheckForSpawnedPlayers()
{
Expand All @@ -56,8 +56,13 @@ protected override void OnServerAndClientsCreated()
m_ClientDisconnectReasonValidated = false;
m_BypassConnectionTimeout = m_PlayerCreation == PlayerCreation.FailValidation;
m_Validated.Clear();
m_ValidationToken = Guid.NewGuid();
var validationToken = Encoding.UTF8.GetBytes(m_ValidationToken.ToString());
m_ValidationToken = string.Empty;
// Exceed the expected MTU size
while (m_ValidationToken.Length < 2000)
{
m_ValidationToken += Guid.NewGuid().ToString();
}
var validationToken = Encoding.UTF8.GetBytes(m_ValidationToken);
m_ServerNetworkManager.ConnectionApprovalCallback = NetworkManagerObject_ConnectionApprovalCallback;
m_ServerNetworkManager.NetworkConfig.PlayerPrefab = m_PlayerCreation == PlayerCreation.Prefab ? m_PlayerPrefab : null;
if (m_PlayerCreation == PlayerCreation.PrefabHash)
Expand All @@ -66,7 +71,6 @@ protected override void OnServerAndClientsCreated()
}
m_ServerNetworkManager.NetworkConfig.ConnectionApproval = true;
m_ServerNetworkManager.NetworkConfig.ConnectionData = validationToken;

foreach (var client in m_ClientNetworkManagers)
{
client.NetworkConfig.PlayerPrefab = m_PlayerCreation == PlayerCreation.Prefab ? m_PlayerPrefab : null;
Expand Down