Skip to content

DO NOT MERGE YET: Action Reference - PR #1 #555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 55 commits into from
Oct 14, 2024

Conversation

suearkinunity
Copy link
Contributor

Purpose of this PR

Updating the Action Reference pages.

There are a lot of them, so I'm daisy chaining multiple PRs to make reviews easier. This is the first PR.

Links

Jira: DOCATT-5849

Comments to Reviewers

First PR of several. Docs only.

Sue Arkin and others added 8 commits August 14, 2024 08:39
1. Edited the page
2. Update the action name on the landing page
I don't think we have bevel faces as a standalone tool anymore. I think it's bevel edges, with the face edit mode selected.
Updated
Updated Bridge Edges and clarified (I hope) what open edges mean.
Since you can now bevel faces from the same tool, I replaced the example
Replaced the example because this tool now does two things
@unity-cla-assistant
Copy link

unity-cla-assistant commented Aug 16, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 3 committers have signed the CLA.

✅ modrimkus-unity
❌ Sue Arkin
❌ suearkinunity


Sue Arkin seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@JonMUnity
Copy link
Contributor

to make reviews easier

Thanks 😃

Sue Arkin and others added 15 commits August 22, 2024 11:30
Plus two small edits to other pages
Merged into one page.
My thinking was that a user won't know whether they need a loop or ring selection until they've read the docs. Therefore, those two options need to be directly compared.
Some of those are guesses, but they'll do for now. I'll tidy it up again later.
Not sure the Shift feature still exists; asked about it.
Action ref PR #4 - merging into my other branch, not Master
Action ref PR #3 - merging into my other branch, *not* into Master
Sue Arkin and others added 21 commits September 5, 2024 10:04
Making it match Msater
Also noticed some bad nesting
But I have some questions
I was using a couple of wrong files.

Also, I'm killing the Tools vs Actions page. First of all, we can't keep calling them actions because Actions is a category of Actions, and we can't do that to our poor users. Second, this page duplicates information that's better presented in its own context, such as creating meshes and the so-called actions. The conceptual difference between tool and action is really not something users need to worry themselves with.
Got rid of the inset page, because it's just a way to use Extrude
Tidying table
Undoing changes in the MAT files
@suearkinunity suearkinunity changed the base branch from master to suearkin-DOCATT-6821 October 14, 2024 13:03
@suearkinunity suearkinunity changed the base branch from suearkin-DOCATT-6821 to master October 14, 2024 13:04
@suearkinunity suearkinunity changed the base branch from master to suearkin-DOCATT-6821 October 14, 2024 14:13
Resolving merge conflict
Resolving merge conflicts
@suearkinunity
Copy link
Contributor Author

Merging into a working branch, not Master.
This merge consolidates all the TOC reorg PRs into a single, giant PR.

@suearkinunity suearkinunity merged commit d2645c8 into suearkin-DOCATT-6821 Oct 14, 2024
1 of 6 checks passed
@suearkinunity suearkinunity deleted the suearkinunity-DOCATT-5849 branch October 14, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants