Skip to content

Conversation

ervteng
Copy link
Contributor

@ervteng ervteng commented Mar 10, 2020

Proposed change(s)

When the Optimizer was split from the Policy, SAC was still using the Policy's reward signals to write the reward values to Tensorboard. This meant that the Policy's reward stats (e.g. Extrinsic Reward, GAIL Reward) was always 0.

This PR fixes the bug and removes the unnecessary reward_signals dict in Policy.

Types of change(s)

  • Bug fix
  • New feature
  • Code refactor
  • Breaking change
  • Documentation update
  • Other (please describe)

Checklist

  • Added tests that prove my fix is effective or that my feature works
  • Updated the changelog (if applicable)
  • Updated the documentation (if applicable)
  • Updated the migration guide (if applicable)

Other comments

@ervteng ervteng requested a review from andrewcoh March 10, 2020 23:09
Copy link
Contributor

@andrewcoh andrewcoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ervteng ervteng merged commit d25348c into master Mar 11, 2020
@delete-merged-branch delete-merged-branch bot deleted the develop-fixsacrewardreporting branch March 11, 2020 17:55
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants