[TF2] Fix prediction for jumping when huntsman is charged/released #797
Conversation
|
Hello, have you seen and read the contributing terms here? https://github.com/ValveSoftware/source-sdk-2013/blob/master/CONTRIBUTING These are visible when you make a PR now, so I am asking for the older PRs. Thanks. |
| { | ||
| EnableJump(); | ||
| } | ||
| // float flCurrentChargeBeginTime = GetInternalChargeBeginTime(); |
There was a problem hiding this comment.
Let's just remove this function override, now.
yeah looks good and i agree with these terms |
…lveSoftware#797) * fix prediction for jumping when huntsman is charged/released * remove SetInternalChargeBeginTime override from CTFCompoundBow ValveSoftware#797 (comment)
|
This also fixes a bug where picking up a charged Huntsman off the ground makes you unable to jump. EDIT; wrong, see below comment |
oh nice so ValveSoftware/Source-1-Games#4013 is fixed as well |
|
Wait sorry, no, still needs a weapon reset call. But it does help a lot since the disable / enable jump isn't stateful. |
|
tested before and after this pr, not sure if this is the correct way to reproduce that bug:
before this pr: you can't jump until you die, or drop the bow, or change your primary, or charge the bow again |
|
Ah interesting, maybe it is fixed, but to me charge time seems like it'd persist and not sure why it'd be updating like that. Maybe because it's not stateful, there's something in idle or something that updates charge time and we don't need a full reset to reset state? Any case, it definitely might even fix some inverse cases too, where you get stuck in jump disable if you pickup weapons while still charged? |
…lveSoftware#797) * fix prediction for jumping when huntsman is charged/released * remove SetInternalChargeBeginTime override from CTFCompoundBow ValveSoftware#797 (comment)
* Update CONTRIBUTING * Add CONTRIBUTING text to PR template * Fix radial fog not being enabled in 3D sky on official maps * Add convar to control max MvM robots * Fix PLAYER_FLAG_BITS truncating m_fFlags sent to clients * Fix middle mouse kicking you in Passtime * tf2: Fix prediction for jumping when huntsman is charged/released (ValveSoftware#797) * fix prediction for jumping when huntsman is charged/released * remove SetInternalChargeBeginTime override from CTFCompoundBow ValveSoftware#797 (comment) * Remove temporary player jingle files if tf_delete_temp_files is enabled * tf2: Fix crash with game_round_win in koth Fixes ValveSoftware/Source-1-Games#4254 * Move .357 snap after firing to client-side * [TF2] Add prediction for thermal thruster + self-stun (ValveSoftware#908) * Remove MFC dependency in the launcher exe (afxres.h > winres.h) * Sync the public SDK with latest from TF2 Includes a manually merged MRs from wgetJane wrt. scattergun prediction and minktusk with readme changes. --------- Co-authored-by: Autumn Ashton <[email protected]> Co-authored-by: ficool2 <[email protected]> Co-authored-by: copperpixel <[email protected]> Co-authored-by: wget <[email protected]> Co-authored-by: AndrewBetson <[email protected]> Co-authored-by: doclic <[email protected]> Co-authored-by: speedvoltage <[email protected]> Co-authored-by: Josh Dowell <[email protected]>
* Update CONTRIBUTING * Add CONTRIBUTING text to PR template * Fix radial fog not being enabled in 3D sky on official maps * Add convar to control max MvM robots * Fix PLAYER_FLAG_BITS truncating m_fFlags sent to clients * Fix middle mouse kicking you in Passtime * tf2: Fix prediction for jumping when huntsman is charged/released (ValveSoftware#797) * fix prediction for jumping when huntsman is charged/released * remove SetInternalChargeBeginTime override from CTFCompoundBow ValveSoftware#797 (comment) * Remove temporary player jingle files if tf_delete_temp_files is enabled * tf2: Fix crash with game_round_win in koth Fixes ValveSoftware/Source-1-Games#4254 * Move .357 snap after firing to client-side * [TF2] Add prediction for thermal thruster + self-stun (ValveSoftware#908) * Remove MFC dependency in the launcher exe (afxres.h > winres.h) * Sync the public SDK with latest from TF2 Includes a manually merged MRs from wgetJane wrt. scattergun prediction and minktusk with readme changes. --------- Co-Authored-By: Autumn Ashton <[email protected]> Co-Authored-By: ficool2 <[email protected]> Co-Authored-By: copperpixel <[email protected]> Co-Authored-By: wget <[email protected]> Co-Authored-By: AndrewBetson <[email protected]> Co-Authored-By: doclic <[email protected]> Co-Authored-By: speedvoltage <[email protected]> Co-Authored-By: Josh Dowell <[email protected]>
partially fixes this issue: ValveSoftware/Source-1-Games#6017
(in the vids below, i press jump immediately after charging 3 times, then jump immediately after releasing 3 times, then jump immediately after holstering 3 times)
unfixed, net_fakelag 100:
2025-02-25.10-29-37.mp4
fixed, net_fakelag 100:
2025-02-25.10-31-36.mp4
this pr adds CTFWeaponBase::OwnerCanJump (similar to the existing CTFWeaponBase::OwnerCanTaunt)