Skip to content
This repository was archived by the owner on Dec 22, 2021. It is now read-only.

BinarySIMD.md doesn't document representation of LaneIdxN #242

Closed
RReverser opened this issue Jun 3, 2020 · 2 comments · Fixed by #252 or #253
Closed

BinarySIMD.md doesn't document representation of LaneIdxN #242

RReverser opened this issue Jun 3, 2020 · 2 comments · Fixed by #252 or #253

Comments

@RReverser
Copy link
Member

The SIMD instruction encodings table in BinarySIMD.md references LaneIdx32, LaneIdx16, etc., but doesn't define their representation anywhere.

I've been pointed to https://github.com/WebAssembly/simd/blob/master/proposals/simd/SIMD.md#immediate-operands which does mention all of these are just single bytes, but it would be useful to encode this in the binary representation document as well.

Additionally, the name in the explainer (ImmLaneIdxN) mismatches the one used in BinarySIMD (LaneIdxN), leading to further potential confusion.

@RReverser
Copy link
Member Author

@ngzhian Thanks for the PR! FWIW your PR auto-closed this issue, but the last part from the description:

Additionally, the name in the explainer (ImmLaneIdxN) mismatches the one used in BinarySIMD (LaneIdxN), leading to further potential confusion.

still remains.

ngzhian added a commit to ngzhian/simd that referenced this issue Jun 10, 2020
@ngzhian
Copy link
Member

ngzhian commented Jun 10, 2020

Ah! #253 should fix this, thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants