This repository was archived by the owner on Aug 22, 2022. It is now read-only.
Ship emscripten library cache in-place #644
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now that emscripten uses an in-tree cache just ship it in place. This also means the emsdk doesn't have to copy any of this during post-install.
sbc100
added a commit
to emscripten-core/emsdk
that referenced
this pull request
May 13, 2020
Now that emscripten uses an in-tree cache directory there is no need to copy the pre-built libraries around. See: WebAssembly/waterfall#644 Also for the sake of older versions of emscripten explictly set EM_CACHE environment variable to point to the in-tree cache directory.
sbc100
added a commit
to emscripten-core/emsdk
that referenced
this pull request
May 13, 2020
Now that emscripten uses an in-tree cache directory there is no need to copy the pre-built libraries around. See: WebAssembly/waterfall#644 Also for the sake of older versions of emscripten explictly set EM_CACHE environment variable to point to the in-tree cache directory.
kripken
approved these changes
May 13, 2020
|
If somehow we weren't copying it from the new place, is the emsdk github CI the only place this would get tested I guess? |
|
Yes, emsdk CI is that only place we ensure this works I believe. This change will break the emsdk CI when the next release is made unless we land the emsdk-side of this change too: emscripten-core/emsdk#501. This emsdk change allows the cache to be used in-place rather than copied around. |
sbc100
added a commit
to emscripten-core/emsdk
that referenced
this pull request
May 13, 2020
Now that emscripten uses an in-tree cache directory there is no need to copy the pre-built libraries around. See: WebAssembly/waterfall#644 Also for the sake of older versions of emscripten explictly set EM_CACHE environment variable to point to the in-tree cache directory.
sbc100
added a commit
to emscripten-core/emsdk
that referenced
this pull request
May 13, 2020
Now that emscripten uses an in-tree cache directory there is no need to copy the pre-built libraries around. See: WebAssembly/waterfall#644 Also for the sake of older versions of emscripten explictly set EM_CACHE environment variable to point to the in-tree cache directory.
sbc100
added a commit
to emscripten-core/emsdk
that referenced
this pull request
May 13, 2020
See: WebAssembly/waterfall#644 For the sake of older versions of emscripten explicitly set EM_CACHE environment variable to point to the in-tree cache directory.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that emscripten uses an in-tree cache just ship it in place.
This also means the emsdk doesn't have to copy any of this during
post-install.