-
Notifications
You must be signed in to change notification settings - Fork 744
Update default emscripten cache directory #501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
73ee72f
to
88586b1
Compare
Now that emscripten uses an in-tree cache directory there is no need to copy the pre-built libraries around. See: WebAssembly/waterfall#644 Also for the sake of older versions of emscripten explictly set EM_CACHE environment variable to point to the in-tree cache directory.
This change is more focused now, and its compatible with SDK build both before and after the pre-built libraries were moved. |
@@ -158,12 +157,10 @@ def run_emsdk(cmd): | |||
|
|||
print('test tot-upstream') | |||
run_emsdk('install tot-upstream') | |||
assert not os.path.exists(LIBC) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why can't we check this any more?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I should have explained. This sequence of assert was checking the "activate" re-installs libraries in the cache.
However, in the now model there is no "install into cache step". The cache is just part of the tar archive.. which means if you want to restore the cache after a --clear-cache
you need to for a re-install from the tar archive (or just let it get built on demand).
Now that emscripten uses an in-tree cache directory there is no
need to copy the pre-built libraries around.
See: WebAssembly/waterfall#644
Also for the sake of older versions of emscripten explictly set
EM_CACHE environment variable to point to the in-tree cache
directory.