CP-1125 Fix incorrect grammer in format task output #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks, your very responsive |
|
+1 |
|
+1 to doc change, but why for CI fail? |
|
Looks like it's an issue with Dart 1.13, I'm looking into it. |
|
This should fix the CI failure once merged: #98 |
You're --> Your
maxwellpeterson-wf
force-pushed
the
grammar-format-task
branch
from
17e1b4a to
b48a60d
Compare
Current coverage is
|
|
+1 |
|
@jayudey-wf ready for merge |
jayudey-wf
changed the title
|
QA Resource Approval: +10
Merging into master. |
jayudey-wf
added a commit
that referenced
this pull request
Nov 20, 2015
CP-1125 Fix incorrect grammer in format task output
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
"You're" was being used instead of "Your" in the sentence "You're Dart code is good to go!"
Changes
Source:
Tests:
Areas of Regression
Testing
Code Review
@trentgrover-wf
@evanweible-wf
@dustinlessard-wf
FYI @jayudey-wf