Skip to content

CP-1124 Fix browser file detection (dart2js output changed) #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 20, 2015

Conversation

evanweible-wf
Copy link
Contributor

Issue

  • The dart2js analyze output that we use to detect whether or not a dart file imports dart:html changed from "Error: library not found" to "Error: library not supported"
  • Also, the project paths for browser/vm test fixtures were swapped

Changes

Source:

  • Use a regex to detect either the old error message or the new one so that this detection works on pre-1.13 and 1.13
  • Fix the project fixture paths

Tests:

  • Current tests already cover this (which is why our CI started failing)

Areas of Regression

  • Coverage collection on browser tests without a custom HTML file

Testing

  • CI (which is on 1.13 now) passes

Code Review

@trentgrover-wf
@maxwellpeterson-wf
@dustinlessard-wf
@jayudey-wf

@trentgrover-wf
Copy link
Contributor

+1

@codecov-io
Copy link

Current coverage is 48.05%

Merging #98 into master will not affect coverage as of 8708cf7

Powered by Codecov. Updated on successful CI builds.

@maxwellpeterson-wf
Copy link
Member

+1

1 similar comment
@dustinlessard-wf
Copy link

+1

@evanweible-wf
Copy link
Contributor Author

@jayudey-wf ready for merge.

@jayudey-wf jayudey-wf changed the title Fix browser file detection (dart2js output changed) CP-1124 Fix browser file detection (dart2js output changed) Nov 20, 2015
@jayudey-wf
Copy link
Contributor

QA Resource Approval: +10

  • Testing instruction
  • Dev +1's
  • Dev/QA +10 with detail of what was tested
    • verified that travis build completed successfully
  • Unit test created/updated
  • All unit tests pass

Merging into master.

jayudey-wf added a commit that referenced this pull request Nov 20, 2015
CP-1124 Fix browser file detection (dart2js output changed)
@jayudey-wf jayudey-wf merged commit 91bf868 into master Nov 20, 2015
@evanweible-wf evanweible-wf deleted the dart-1.13-fix branch November 24, 2015 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants