[DICOM Archive] Fully react-rendered + written in ES6 #2397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alisterdev
added
Category: Feature
jacobpenny
reviewed
Nov 7, 2016
| /* global QueryString */ | ||
|
|
||
| const propTypes = {}; | ||
| const defaultProps = {}; |
There was a problem hiding this comment.
Might as well define these now
There was a problem hiding this comment.
@jacobpenny The default properties are page specific
stellarxo
added
the
Passed manual tests
|
I think it is worth reconsidering the use of inheritance here because it isn't idiomatic in the React world. Facebook has a pretty strong opinion on this: https://facebook.github.io/react/docs/composition-vs-inheritance.html#so-what-about-inheritance Also summed up nicely by one of the core React contributors here: |
alisterdev
added
State: Needs work
alisterdev
force-pushed
the
161027_react_loris_page
branch
from
664d6ad to
f337b83
Compare
|
@jacobpenny Scratched the whole inheritance idea as per your suggestion and simplified filter implementation instead. |
alisterdev
added
Request Code Review
and removed
State: Needs work
alisterdev
changed the title
… parent component
alisterdev
added a commit
to alisterdev/Loris
that referenced
this pull request
Jan 20, 2017
* Add LorisPage component to Loris * Update dicom_archive to use LorisPage * Remove unused statement * PHPCS * Remove LorisPage and move behaviour back to module * Update querystring API for less code and more pleasant experience * Add QueryString to global eslint ignore list * Clear tpl as everything is rendered in react now * Update mri_violation to use new QueryString API * Replace DynamicTable with StaticTable since all data is loaded in the parent component
MounaSafiHarab
pushed a commit
to MounaSafiHarab/Loris
that referenced
this pull request
Jan 20, 2017
* Add LorisPage component to Loris * Update dicom_archive to use LorisPage * Remove unused statement * PHPCS * Remove LorisPage and move behaviour back to module * Update querystring API for less code and more pleasant experience * Add QueryString to global eslint ignore list * Clear tpl as everything is rendered in react now * Update mri_violation to use new QueryString API * Replace DynamicTable with StaticTable since all data is loaded in the parent component
taracampbell
pushed a commit
to taracampbell/Loris
that referenced
this pull request
Mar 9, 2017
* Add LorisPage component to Loris * Update dicom_archive to use LorisPage * Remove unused statement * PHPCS * Remove LorisPage and move behaviour back to module * Update querystring API for less code and more pleasant experience * Add QueryString to global eslint ignore list * Clear tpl as everything is rendered in react now * Update mri_violation to use new QueryString API * Replace DynamicTable with StaticTable since all data is loaded in the parent component
jstirling91
pushed a commit
to jstirling91/Loris
that referenced
this pull request
May 8, 2017
* Add LorisPage component to Loris * Update dicom_archive to use LorisPage * Remove unused statement * PHPCS * Remove LorisPage and move behaviour back to module * Update querystring API for less code and more pleasant experience * Add QueryString to global eslint ignore list * Clear tpl as everything is rendered in react now * Update mri_violation to use new QueryString API * Replace DynamicTable with StaticTable since all data is loaded in the parent component
kongtiaowang
pushed a commit
to kongtiaowang/Loris
that referenced
this pull request
Jan 31, 2018
* Add LorisPage component to Loris * Update dicom_archive to use LorisPage * Remove unused statement * PHPCS * Remove LorisPage and move behaviour back to module * Update querystring API for less code and more pleasant experience * Add QueryString to global eslint ignore list * Clear tpl as everything is rendered in react now * Update mri_violation to use new QueryString API * Replace DynamicTable with StaticTable since all data is loaded in the parent component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New cool features below 🎉
dicom_archiveas an example module written in ES6