Removed internal state from several input components #2433
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me, but I think @alisterdev should review it since he's more familiar with the JS being modified. @jstirling91 says that the Form.js was written for the instrument builder, so can you make sure that's tested with this change? |
|
Yeah actually @alisterdev already found a couple issues with this that need to be addressed (mostly updates to code using these components). I'll make sure to test instrument builder too. |
jacobpenny
added
the
State: Needs work
|
@driusan Instrument builder uses form elements simply to display UI (i.e no input), hence it is not affected by this change. (also I tested it to make sure) |
alisterdev
suggested changes
Nov 22, 2016
3 tasks
These components were duplicating/mirroring state when they could simply use props. This change gives us a single source of truth for state and is more in line with React best practices.
alisterdev
force-pushed
the
controlled-form-components
branch
from
461437d to
b5a0ab1
Compare
alisterdev
approved these changes
Dec 23, 2016
|
So, I found how to fix the bugs without major code changes and pushed all the necessary updates. |
alisterdev
added
PassedCodeReview
Cleanup
alisterdev
pushed a commit
to alisterdev/Loris
that referenced
this pull request
Jan 20, 2017
* Removed internal state from several input components These components were duplicating/mirroring state when they could simply use props. This change gives us a single source of truth for state and is more in line with React best practices. * Only show input errors for requried fields when empty string is passed * Update form elements used in media * Pass values to form elements
MounaSafiHarab
pushed a commit
to MounaSafiHarab/Loris
that referenced
this pull request
Jan 20, 2017
* Removed internal state from several input components These components were duplicating/mirroring state when they could simply use props. This change gives us a single source of truth for state and is more in line with React best practices. * Only show input errors for requried fields when empty string is passed * Update form elements used in media * Pass values to form elements
jstirling91
pushed a commit
to jstirling91/Loris
that referenced
this pull request
May 8, 2017
* Removed internal state from several input components These components were duplicating/mirroring state when they could simply use props. This change gives us a single source of truth for state and is more in line with React best practices. * Only show input errors for requried fields when empty string is passed * Update form elements used in media * Pass values to form elements
kongtiaowang
pushed a commit
to kongtiaowang/Loris
that referenced
this pull request
Jan 31, 2018
* Removed internal state from several input components These components were duplicating/mirroring state when they could simply use props. This change gives us a single source of truth for state and is more in line with React best practices. * Only show input errors for requried fields when empty string is passed * Update form elements used in media * Pass values to form elements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These components were duplicating/mirroring state when they could use props instead. This change gives us a single source of truth for state and is more in line with the React idiom of preferring controlled components to uncontrolled ones.