-
Notifications
You must be signed in to change notification settings - Fork 378
Adding PineH64 SBC support #322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Good afternoon, I noticed my pull request has failed the check due to a formatting issue. I am unsure what this issue is. When creating the file I used the pine64.py file as a reference. I see no discrepancies in their formatting. |
Thanks. You will probably also need to add an |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add the board to this huge else-if block:
https://github.com/adafruit/Adafruit_Blinka/blob/master/src/board.py#L38-L160
PineH64 has now been added to the large elsif block. |
Looks like you're missing an asterisk at the end of your import statement. |
src/board.py
Outdated
from adafruit_blinka.board.pine64 import * | ||
|
||
elif board_id == ap_board.PINEH64: | ||
from adafruit_blinka.board.pineH64 import |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line should be:
from adafruit_blinka.board.pineH64 import *
Hey, Sorry for the super long wait. I added the asterisk. |
Thanks for following up. We need to get adafruit/Adafruit_Python_PlatformDetect#90 merged in before this will pass and there's some long comment lines stopping it from passing the checks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good.
I have added the "microcontroller" file and "board" file for the Allwinner H6 based PineH64. I believe these are the only necessary files for Blinka compatibility.
I followed the guide provided by Adafruit at the following link:
https://learn.adafruit.com/adding-a-single-board-computer-to-blinka/
I will also be creating a pull request for adafruit_platformdetect to add PineH64 detection.