Skip to content

Conversation

dmanla
Copy link
Contributor

@dmanla dmanla commented Jul 23, 2020

I have added the "microcontroller" file and "board" file for the Allwinner H6 based PineH64. I believe these are the only necessary files for Blinka compatibility.

I followed the guide provided by Adafruit at the following link:
https://learn.adafruit.com/adding-a-single-board-computer-to-blinka/

I will also be creating a pull request for adafruit_platformdetect to add PineH64 detection.

@dmanla
Copy link
Contributor Author

dmanla commented Jul 23, 2020

Good afternoon,

I noticed my pull request has failed the check due to a formatting issue. I am unsure what this issue is. When creating the file I used the pine64.py file as a reference. I see no discrepancies in their formatting.

@makermelissa
Copy link
Collaborator

Thanks. You will probably also need to add an elif line to board.py and the checks will fail until your PlatformDetect PR is in.

Copy link
Collaborator

@makermelissa makermelissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add the board to this huge else-if block:
https://github.com/adafruit/Adafruit_Blinka/blob/master/src/board.py#L38-L160

@dmanla
Copy link
Contributor Author

dmanla commented Aug 5, 2020

PineH64 has now been added to the large elsif block.

@makermelissa
Copy link
Collaborator

Looks like you're missing an asterisk at the end of your import statement.

src/board.py Outdated
from adafruit_blinka.board.pine64 import *

elif board_id == ap_board.PINEH64:
from adafruit_blinka.board.pineH64 import
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line should be:
from adafruit_blinka.board.pineH64 import *

@dmanla
Copy link
Contributor Author

dmanla commented Oct 14, 2020

Hey,

Sorry for the super long wait. I added the asterisk.

@makermelissa
Copy link
Collaborator

Thanks for following up. We need to get adafruit/Adafruit_Python_PlatformDetect#90 merged in before this will pass and there's some long comment lines stopping it from passing the checks.

Copy link
Collaborator

@makermelissa makermelissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.

@makermelissa makermelissa merged commit 15891fa into adafruit:master Nov 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants