Added PineH64 detection; Modified Allwinner A64 Detection #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In chip.py hardware identifiers take precedence over all other forms of chip detection. This causes issues with differentiating between the Allwinner H6 and Allwinner A64. Both the Allwinner H6 and Allwinner A64 return "sun50iw1p1 when checking the cpu info Hardware field. I have added logic to prevent the use of sun50iw1p1 as an identifier. I have added additional logic which successfully detects the Allwinner H6.
makermelissa
requested changes
Jul 28, 2020
makermelissa
requested changes
Oct 14, 2020
makermelissa
approved these changes
Nov 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding PineH64 and Allwinner H6 detection I ran into an issue; Both the Allwinner A64 and Allwinner H6 return sun50iw1p1 as a cpu info hardware identifier. Because of this I do not feel it should be considered a valid chip identifier in this context. I have added logic which ignores sun50iw1p1 if it is the hardware identifier.
I have added logic for detecting the Allwinner H6 and PineH64.