Skip to content

feat: expose scroll event #2011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 21, 2020
Merged

feat: expose scroll event #2011

merged 8 commits into from
Apr 21, 2020

Conversation

qili26
Copy link
Contributor

@qili26 qili26 commented Apr 21, 2020

  1. Expose scroll event. Event can be used to check whether the scroll is at the bottom for endless data loading.

endless scrolling

@qili26 qili26 self-assigned this Apr 21, 2020
@qili26
Copy link
Contributor Author

qili26 commented Apr 21, 2020

Link to this #1854

@qili26 qili26 linked an issue Apr 21, 2020 that may be closed by this pull request
@qili26 qili26 marked this pull request as ready for review April 21, 2020 00:36
@qili26 qili26 requested review from nstepien and amanmahajan7 April 21, 2020 00:36
@qili26 qili26 requested review from amanmahajan7 and nstepien April 21, 2020 13:13
@@ -37,7 +37,6 @@ import {
RowExpandToggleEvent,
RowRendererProps,
RowsUpdateEvent,
ScrollPosition,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This type isn't used anywhere anymore, let's delete it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, I didn't know this detail.

@qili26 qili26 requested a review from nstepien April 21, 2020 13:51
Copy link
Contributor

@amanmahajan7 amanmahajan7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work

@amanmahajan7 amanmahajan7 merged commit 7614c8e into canary Apr 21, 2020
@amanmahajan7 amanmahajan7 deleted the ql-scroll branch April 21, 2020 14:05
keriat pushed a commit to superform-xyz/react-data-grid that referenced this pull request Jan 10, 2024
## [5.1.0](v5.0.4...5.1.0) (2024-01-10)

### Features

* Add DataGridComponentsProvider component and DataGrid.components prop ([adazzle#2754](https://github.com/superform-xyz/react-data-grid/issues/2754)) ([f864291](f864291))
* Add support for flex column width ([adazzle#2839](https://github.com/superform-xyz/react-data-grid/issues/2839)) ([4a136ad](4a136ad))
* expose scroll event ([adazzle#2011](https://github.com/superform-xyz/react-data-grid/issues/2011)) ([7614c8e](7614c8e))
* RTL ([adazzle#2803](https://github.com/superform-xyz/react-data-grid/issues/2803)) ([c0e4a63](c0e4a63))
* semantic release installed and configured ([e71bfe6](e71bfe6))

### Bug Fixes

* drag jumps to the right due to the failed merge ([adazzle#1564](https://github.com/superform-xyz/react-data-grid/issues/1564)) ([7033a1b](7033a1b))
* isSelectedCellEditable row getter idx ([adazzle#1743](https://github.com/superform-xyz/react-data-grid/issues/1743)) ([018f137](018f137))
* package-lock.json added to version control ([df39113](df39113))

### Reverts

* Revert "Dependabot: set versioning-strategy to increase (adazzle#2479)" (adazzle#2511) ([0bedc81](0bedc81))
keriat pushed a commit to superform-xyz/react-data-grid that referenced this pull request Jan 10, 2024
## [5.1.0](v5.0.4...5.1.0) (2024-01-10)

### Features

* Add DataGridComponentsProvider component and DataGrid.components prop ([adazzle#2754](https://github.com/superform-xyz/react-data-grid/issues/2754)) ([f864291](f864291))
* Add support for flex column width ([adazzle#2839](https://github.com/superform-xyz/react-data-grid/issues/2839)) ([4a136ad](4a136ad))
* expose scroll event ([adazzle#2011](https://github.com/superform-xyz/react-data-grid/issues/2011)) ([7614c8e](7614c8e))
* RTL ([adazzle#2803](https://github.com/superform-xyz/react-data-grid/issues/2803)) ([c0e4a63](c0e4a63))
* semantic release installed and configured ([e71bfe6](e71bfe6))

### Bug Fixes

* drag jumps to the right due to the failed merge ([adazzle#1564](https://github.com/superform-xyz/react-data-grid/issues/1564)) ([7033a1b](7033a1b))
* isSelectedCellEditable row getter idx ([adazzle#1743](https://github.com/superform-xyz/react-data-grid/issues/1743)) ([018f137](018f137))
* package-lock.json added to version control ([df39113](df39113))

### Reverts

* Revert "Dependabot: set versioning-strategy to increase (adazzle#2479)" (adazzle#2511) ([0bedc81](0bedc81))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Question] Future plans, roadmap, data lazy loading, paging
3 participants