Feature: Add DataGridComponentsProvider component and DataGrid.components prop #2754
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2754 +/- ##
==========================================
- Coverage 96.27% 96.16% -0.12%
==========================================
Files 34 37 +3
Lines 1209 1226 +17
Branches 379 383 +4
==========================================
+ Hits 1164 1179 +15
- Misses 45 47 +2
|
amanmahajan7
commented
Dec 14, 2021
| > | ||
| {column.name} | ||
| </SortableHeaderCell> | ||
| <HeaderRenderer column={column} {...props} /> |
There was a problem hiding this comment.
With this new change we do not have to reimplement sorting everytime we override headerRenderer
amanmahajan7
changed the title
nstepien
reviewed
Feb 3, 2022
Co-authored-by: Nicolas Stepien <[email protected]>
Co-authored-by: Nicolas Stepien <[email protected]>
amanmahajan7
changed the title
|
I did not add an example for |
nstepien
reviewed
Feb 4, 2022
nstepien
reviewed
Feb 4, 2022
nstepien
reviewed
Feb 7, 2022
README.md
Outdated
| interface Components<TRow, TSummaryRow> { | ||
| sortIcon?: Maybe<ComponentType<SortIconProps>>; | ||
| checkboxFormatter?: Maybe< | ||
| ForwardRefExoticComponent<CheckboxFormatterProps & RefAttributes<HTMLInputElement>> |
There was a problem hiding this comment.
Need to add | ComponentType
Co-authored-by: Nicolas Stepien <[email protected]>
Co-authored-by: Nicolas Stepien <[email protected]>
nstepien
approved these changes
Feb 7, 2022
keriat
pushed a commit
to superform-xyz/react-data-grid
that referenced
this pull request
Jan 10, 2024
## [5.1.0](v5.0.4...5.1.0) (2024-01-10) ### Features * Add DataGridComponentsProvider component and DataGrid.components prop ([adazzle#2754](https://github.com/superform-xyz/react-data-grid/issues/2754)) ([f864291](f864291)) * Add support for flex column width ([adazzle#2839](https://github.com/superform-xyz/react-data-grid/issues/2839)) ([4a136ad](4a136ad)) * expose scroll event ([adazzle#2011](https://github.com/superform-xyz/react-data-grid/issues/2011)) ([7614c8e](7614c8e)) * RTL ([adazzle#2803](https://github.com/superform-xyz/react-data-grid/issues/2803)) ([c0e4a63](c0e4a63)) * semantic release installed and configured ([e71bfe6](e71bfe6)) ### Bug Fixes * drag jumps to the right due to the failed merge ([adazzle#1564](https://github.com/superform-xyz/react-data-grid/issues/1564)) ([7033a1b](7033a1b)) * isSelectedCellEditable row getter idx ([adazzle#1743](https://github.com/superform-xyz/react-data-grid/issues/1743)) ([018f137](018f137)) * package-lock.json added to version control ([df39113](df39113)) ### Reverts * Revert "Dependabot: set versioning-strategy to increase (adazzle#2479)" (adazzle#2511) ([0bedc81](0bedc81))
keriat
pushed a commit
to superform-xyz/react-data-grid
that referenced
this pull request
Jan 10, 2024
## [5.1.0](v5.0.4...5.1.0) (2024-01-10) ### Features * Add DataGridComponentsProvider component and DataGrid.components prop ([adazzle#2754](https://github.com/superform-xyz/react-data-grid/issues/2754)) ([f864291](f864291)) * Add support for flex column width ([adazzle#2839](https://github.com/superform-xyz/react-data-grid/issues/2839)) ([4a136ad](4a136ad)) * expose scroll event ([adazzle#2011](https://github.com/superform-xyz/react-data-grid/issues/2011)) ([7614c8e](7614c8e)) * RTL ([adazzle#2803](https://github.com/superform-xyz/react-data-grid/issues/2803)) ([c0e4a63](c0e4a63)) * semantic release installed and configured ([e71bfe6](e71bfe6)) ### Bug Fixes * drag jumps to the right due to the failed merge ([adazzle#1564](https://github.com/superform-xyz/react-data-grid/issues/1564)) ([7033a1b](7033a1b)) * isSelectedCellEditable row getter idx ([adazzle#1743](https://github.com/superform-xyz/react-data-grid/issues/1743)) ([018f137](018f137)) * package-lock.json added to version control ([df39113](df39113)) ### Reverts * Revert "Dependabot: set versioning-strategy to increase (adazzle#2479)" (adazzle#2511) ([0bedc81](0bedc81))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DataGrid.componentsprop. This replacesrowRendererandnoRowsFallbackprops.DataGridComponentsProvider. This would be helpful to replace components globally