-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Feature: Add DataGridComponentsProvider component and DataGrid.components prop #2754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2754 +/- ##
==========================================
- Coverage 96.27% 96.16% -0.12%
==========================================
Files 34 37 +3
Lines 1209 1226 +17
Branches 379 383 +4
==========================================
+ Hits 1164 1179 +15
- Misses 45 47 +2
|
> | ||
{column.name} | ||
</SortableHeaderCell> | ||
<HeaderRenderer column={column} {...props} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With this new change we do not have to reimplement sorting everytime we override headerRenderer
Co-authored-by: Nicolas Stepien <[email protected]>
Co-authored-by: Nicolas Stepien <[email protected]>
I did not add an example for |
README.md
Outdated
interface Components<TRow, TSummaryRow> { | ||
sortIcon?: Maybe<ComponentType<SortIconProps>>; | ||
checkboxFormatter?: Maybe< | ||
ForwardRefExoticComponent<CheckboxFormatterProps & RefAttributes<HTMLInputElement>> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to add | ComponentType
Co-authored-by: Nicolas Stepien <[email protected]>
Co-authored-by: Nicolas Stepien <[email protected]>
## [5.1.0](v5.0.4...5.1.0) (2024-01-10) ### Features * Add DataGridComponentsProvider component and DataGrid.components prop ([adazzle#2754](https://github.com/superform-xyz/react-data-grid/issues/2754)) ([f864291](f864291)) * Add support for flex column width ([adazzle#2839](https://github.com/superform-xyz/react-data-grid/issues/2839)) ([4a136ad](4a136ad)) * expose scroll event ([adazzle#2011](https://github.com/superform-xyz/react-data-grid/issues/2011)) ([7614c8e](7614c8e)) * RTL ([adazzle#2803](https://github.com/superform-xyz/react-data-grid/issues/2803)) ([c0e4a63](c0e4a63)) * semantic release installed and configured ([e71bfe6](e71bfe6)) ### Bug Fixes * drag jumps to the right due to the failed merge ([adazzle#1564](https://github.com/superform-xyz/react-data-grid/issues/1564)) ([7033a1b](7033a1b)) * isSelectedCellEditable row getter idx ([adazzle#1743](https://github.com/superform-xyz/react-data-grid/issues/1743)) ([018f137](018f137)) * package-lock.json added to version control ([df39113](df39113)) ### Reverts * Revert "Dependabot: set versioning-strategy to increase (adazzle#2479)" (adazzle#2511) ([0bedc81](0bedc81))
## [5.1.0](v5.0.4...5.1.0) (2024-01-10) ### Features * Add DataGridComponentsProvider component and DataGrid.components prop ([adazzle#2754](https://github.com/superform-xyz/react-data-grid/issues/2754)) ([f864291](f864291)) * Add support for flex column width ([adazzle#2839](https://github.com/superform-xyz/react-data-grid/issues/2839)) ([4a136ad](4a136ad)) * expose scroll event ([adazzle#2011](https://github.com/superform-xyz/react-data-grid/issues/2011)) ([7614c8e](7614c8e)) * RTL ([adazzle#2803](https://github.com/superform-xyz/react-data-grid/issues/2803)) ([c0e4a63](c0e4a63)) * semantic release installed and configured ([e71bfe6](e71bfe6)) ### Bug Fixes * drag jumps to the right due to the failed merge ([adazzle#1564](https://github.com/superform-xyz/react-data-grid/issues/1564)) ([7033a1b](7033a1b)) * isSelectedCellEditable row getter idx ([adazzle#1743](https://github.com/superform-xyz/react-data-grid/issues/1743)) ([018f137](018f137)) * package-lock.json added to version control ([df39113](df39113)) ### Reverts * Revert "Dependabot: set versioning-strategy to increase (adazzle#2479)" (adazzle#2511) ([0bedc81](0bedc81))
DataGrid.components
prop. This replacesrowRenderer
andnoRowsFallback
props.DataGridComponentsProvider
. This would be helpful to replace components globally