Skip to content
This repository was archived by the owner on Feb 15, 2024. It is now read-only.

Removing the license-maven-plugin from the dependencies #10

Closed

Conversation

sebbader
Copy link
Contributor

@sebbader sebbader commented May 6, 2022

Relates to #9

The build without the dependency worked in my local setting so it seems like the declaration as a plugin is enough.

@sebbader sebbader added this to the Release 1.3.0 milestone May 6, 2022
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Contributor

@mjacoby mjacoby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be followed by an update to java-serializer repository to include the new version of java-model?

@@ -39,7 +39,7 @@


<properties>
<revision>1.1.1</revision>
<revision>1.3.0-SNAPSHOT</revision>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the new version be 1.2.1 instead of 1.3.0 (latest released version is 1.2.0 and for some reason differs from version defined in pom)? There should not be any new or changed funtionality so I wouldn't clasify it as minor change.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following this PR it should be 1.2.1-SNAPSHOT. I really don't have a strong opinion on this but we should make sure it's consistent.

Copy link

@arnoweiss arnoweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We initially added it to check for licenses of transatory dependencies during development-time. Since the model has no dependencies, removing it is a good idea.

@mjacoby
Copy link
Contributor

mjacoby commented May 6, 2022

@alw-iwu AFAIK, this PR does not remove the plugin but only removes the "duplicate dependency" for the plugin which caused it to be included in the final package.

However, I agree that this should be fixed but before merging we need to address the two issues I mentioned before

  • What should be the next version? I propose 1.2.1 instead of 1.3.0
  • Should we also publish a new version of java-serializer to include the latest version?

@sebbader
Copy link
Contributor Author

I am closing this PR as the fix has already happened in the new eclipse repo with eclipse-aas4j/aas4j#23

@sebbader sebbader closed this Sep 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants