Skip to content
This repository was archived by the owner on Feb 15, 2024. It is now read-only.

Removing the license-maven-plugin from the dependencies #10

Closed
wants to merge 1 commit into from
Closed

Removing the license-maven-plugin from the dependencies #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 4 additions & 9 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<modelVersion>4.0.0</modelVersion>
<groupId>io.admin-shell.aas</groupId>
<artifactId>model</artifactId>
<version>1.3.0-SNAPSHOT</version>
<version>${revision}</version>

<!-- Description, name, URL, developers, and scm are required by Sonatype for the Central Repository release -->
<description>This project includes a Java representation of the classes defined in the Asset Administration Shell ontology.</description>
Expand Down Expand Up @@ -39,7 +39,7 @@


<properties>
<revision>1.1.1</revision>
<revision>1.3.0-SNAPSHOT</revision>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the new version be 1.2.1 instead of 1.3.0 (latest released version is 1.2.0 and for some reason differs from version defined in pom)? There should not be any new or changed funtionality so I wouldn't clasify it as minor change.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following this PR it should be 1.2.1-SNAPSHOT. I really don't have a strong opinion on this but we should make sure it's consistent.

<maven.compiler.source>1.8</maven.compiler.source>
<maven.compiler.target>1.8</maven.compiler.target>
<plugin.flatten.version>1.2.2</plugin.flatten.version>
Expand All @@ -48,13 +48,8 @@
<plugin.projectinfo.version>3.1.2</plugin.projectinfo.version>
<gpg.keyname>0xDFCC34A6</gpg.keyname>
</properties>
<dependencies>
<dependency>
<groupId>com.mycila</groupId>
<artifactId>license-maven-plugin</artifactId>
<version>${plugin.license.version}</version>
</dependency>
</dependencies>


<build>
<plugins>
<plugin>
Expand Down