Skip to content

Fix SearchField to call onKeyDown #2617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 30, 2021
Merged

Fix SearchField to call onKeyDown #2617

merged 3 commits into from
Nov 30, 2021

Conversation

reidbarber
Copy link
Member

Closes #2253

✅ Pull Request Checklist:

  • Included link to corresponding React Spectrum GitHub Issue.
  • Added/updated unit tests and storybook for this change (for new code or code which already has tests).
  • Filled out test instructions.
  • Updated documentation (if it already exists for this component).
  • Looked at the Accessibility Practices for this feature - Aria Practices

📝 Test Instructions:

Verify new test for onKeyDown passes and user-provided onKeyDown even is called if provided as prop to SearchField.

🧢 Your Project:

RSP

@adobe-bot
Copy link

Build successful! 🎉

@adobe-bot
Copy link

Build successful! 🎉

snowystinger
snowystinger approved these changes Nov 30, 2021
View reviewed changes
Copy link
Member

@snowystinger snowystinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the test!

@reidbarber reidbarber merged commit 86a966c into main Nov 30, 2021
@reidbarber reidbarber deleted the SearchField-onKeyDown-Issue-2253 branch November 30, 2021 22:57
@reidbarber reidbarber mentioned this pull request Dec 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devongovett devongovett devongovett approved these changes

@snowystinger snowystinger snowystinger approved these changes

@LFDanLu LFDanLu LFDanLu approved these changes

@dannify dannify Awaiting requested review from dannify

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[SearchField] onKeyDown event handler never called
5 participants
@reidbarber @adobe-bot @devongovett @snowystinger @LFDanLu