Skip to content

[ new ] Interleaving of Lists #529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Dec 24, 2018
Merged

[ new ] Interleaving of Lists #529

merged 12 commits into from
Dec 24, 2018

Conversation

gallais
Copy link
Member

@gallais gallais commented Nov 12, 2018

This has been sitting on a branch for a while. Might as well start a PR.

@MatthewDaggitt
Copy link
Contributor

Looks good! My only comment is that maybe Split is a bit confusing as a name as when you split something you typically only use a single break. Interleave would be much clearer. Would you object to me changing it?

@MatthewDaggitt MatthewDaggitt added this to the v0.18 milestone Nov 29, 2018
@gallais
Copy link
Member Author

gallais commented Nov 29, 2018

As I said in the first commit message:

I have changed my mind and called it Split because the List being broken down
is the first argument of the relation.

I am a bit uneasy because Interleave xs ys zs intuitively suggests to me that I get
zs by interleaving xs and ys rather than the other way around. That being said, it
is not that big of a deal to me so I won't oppose a name change.

@MatthewDaggitt
Copy link
Contributor

MatthewDaggitt commented Nov 29, 2018

I am a bit uneasy because Interleave xs ys zs intuitively suggests to me that I get
zs by interleaving xs and ys rather than the other way around.

What about if we changed the definition to match that intuition?

@gallais
Copy link
Member Author

gallais commented Nov 29, 2018

That could work. We would presumably need to flip the relations too to keep the
arguments in the same order as the indices'.

@MatthewDaggitt
Copy link
Contributor

I'll give it a go at some point and see what it reads like.

@MatthewDaggitt
Copy link
Contributor

I've updated the name to Interleaving and swapped the argument order. I've also thrown in Propositional interleavings for the sake of it, and move toPermutation there.

@MatthewDaggitt MatthewDaggitt changed the title Interleaving of Lists [ new ] Interleaving of Lists Dec 7, 2018
@MatthewDaggitt MatthewDaggitt merged commit ab43a34 into master Dec 24, 2018
@MatthewDaggitt MatthewDaggitt deleted the interleaving branch December 24, 2018 15:01
@MatthewDaggitt MatthewDaggitt modified the milestones: v0.18, v1.0 Feb 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants