Support file pruning through JsonPredicates and predicates queryRequest parameters #130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmnd1991
reviewed
Nov 6, 2023
server/src/main/java/io/whitefox/core/services/DeltaSharedTable.java
Outdated
Show resolved
Hide resolved
tmnd1991
previously requested changes
Dec 1, 2023
server/src/main/java/io/whitefox/core/services/DeltaSharedTable.java
Outdated
Show resolved
Hide resolved
server/src/main/java/io/whitefox/core/types/predicates/LeafOp.java
Outdated
Show resolved
Hide resolved
server/src/main/java/io/whitefox/core/types/predicates/EvalHelper.java
Outdated
Show resolved
Hide resolved
server/src/main/java/io/whitefox/core/types/predicates/EvalHelper.java
Outdated
Show resolved
Hide resolved
server/src/main/java/io/whitefox/core/types/predicates/EvalHelper.java
Outdated
Show resolved
Hide resolved
server/src/main/java/io/whitefox/core/types/predicates/LeafOpDeserializer.java
Outdated
Show resolved
Hide resolved
duhizjame
force-pushed
the
feature/93-support-parameters-predicatehints-and-jsonpredicatehints-in-querytable-api
branch
from
ca5bb6c to
9553187
Compare
tmnd1991
reviewed
Dec 15, 2023
duhizjame
force-pushed
the
feature/93-support-parameters-predicatehints-and-jsonpredicatehints-in-querytable-api
branch
from
dadbfdc to
fa40ab3
Compare
tmnd1991
reviewed
Dec 19, 2023
duhizjame
force-pushed
the
feature/93-support-parameters-predicatehints-and-jsonpredicatehints-in-querytable-api
branch
from
eba1ae8 to
429e8a9
Compare
duhizjame
force-pushed
the
feature/93-support-parameters-predicatehints-and-jsonpredicatehints-in-querytable-api
branch
2 times, most recently
from
9fc7980 to
9948574
Compare
agilelab-tmnd1991
requested changes
Jan 29, 2024
server/app/src/test/java/io/whitefox/api/deltasharing/server/DeltaSharesApiImplTest.java
Outdated
Show resolved
Hide resolved
server/core/src/main/java/io/whitefox/core/types/predicates/BasePrimitiveTypeNames.java
Outdated
Show resolved
Hide resolved
server/core/src/main/java/io/whitefox/core/types/predicates/LeafEvaluationResult.java
Outdated
Show resolved
Hide resolved
duhizjame
force-pushed
the
feature/93-support-parameters-predicatehints-and-jsonpredicatehints-in-querytable-api
branch
from
26e9791 to
8f18c09
Compare
|
refactored a lot of stuff based on the comments; |
Is this compliant with the spec? https://github.com/delta-io/delta-sharing/blob/main/PROTOCOL.md#primitive-types |
|
it should be; based on the actual protocol update in #203(line 585 in the delta protocol) + even delta standalone refers to this type by its short name all other usages of IntegerType(the io.whitefox.types one) is our internal usage |
…-and-jsonpredicatehints-in-querytable-api
agilelab-tmnd1991
approved these changes
Jan 31, 2024
agilelab-tmnd1991
dismissed
tmnd1991’s stale review
because it's me from another account
agilelab-tmnd1991
changed the title
agilelab-tmnd1991
deleted the
feature/93-support-parameters-predicatehints-and-jsonpredicatehints-in-querytable-api
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.