chore: remove pendulum dependency #258

devin-ai-integration · 2025-01-23T20:14:28Z

Unblocks:

ci: add Python 3.12 support #291

What

Removes Pendulum dependency from the Python CDK
Introduces AirbyteDateTime class for consistent datetime handling
Adds helper functions for datetime operations
Ensures ISO8601/RFC3339 compliance with 'T' delimiter
Handles Unix timestamps in datetime parsing

How

Created AirbyteDateTime class that inherits from datetime
Added helper functions for common operations
Replaced all Pendulum usage with new helpers
Updated tests to use new datetime utilities
Removed Pendulum from dependencies

Testing

Unit tests passing
Linting checks passing
Type checks passing

Link to Devin run: https://app.devin.ai/sessions/cd2adf128d354d6d8e0123af60500f39

- Introduces AirbyteDateTime class for consistent ISO8601/RFC3339 formatting - Adds helper functions for datetime operations - Includes comprehensive test coverage - Prepares for Pendulum removal Co-Authored-By: Aaron <AJ> Steers <[email protected]>

- Remove pendulum imports - Replace pendulum.now() with datetime_helpers.now() - Replace pendulum.parse() with datetime_helpers.parse() - Replace pendulum.DateTime type hints with AirbyteDateTime - Update time arithmetic to use standard datetime operations Co-Authored-By: Aaron <AJ> Steers <[email protected]>

Co-Authored-By: Aaron <AJ> Steers <[email protected]>

devin-ai-integration · 2025-01-23T20:14:31Z

Original prompt:

@Devin In the Python CDK, we want to remove all references to Pendulum so we can remove the dependency. Can you make a plan to do so?

devin-ai-integration · 2025-01-23T20:14:32Z

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

Address comments on this PR. Add "(aside)" to your comment to have me ignore it.
Look at CI failures and help fix them

⚙️ Control Options:

Disable automatic comment and CI monitoring

Co-Authored-By: Aaron <AJ> Steers <[email protected]>

aaronsteers · 2025-01-23T21:53:50Z

/poetry-lock

Poetry-Lock Job Info

This job attempts to re-lock dependencies using poetry lock command. If any changes
are made, those changes will be automatically committed and pushed back to the PR.

Note: This job can only be run by maintainers. On PRs from forks, this command requires
that the PR author has enabled the Allow edits from maintainers option.

poetry lock job started... Check job output.

✅ poetry lock applied successfully.

Resolving dependencies... changes

devin-ai-integration · 2025-01-23T21:55:37Z

Devin is currently unreachable - the session may have died.

pyproject.toml

Co-Authored-By: Aaron <AJ> Steers <[email protected]>

…ecified Co-Authored-By: Aaron <AJ> Steers <[email protected]>

Co-Authored-By: Aaron <AJ> Steers <[email protected]>

…rary Co-Authored-By: Aaron <AJ> Steers <[email protected]>

Co-Authored-By: Aaron <AJ> Steers <[email protected]>

aaronsteers · 2025-01-28T23:17:16Z

/poetry-lock

Poetry-Lock Job Info

This job attempts to re-lock dependencies using poetry lock command. If any changes
are made, those changes will be automatically committed and pushed back to the PR.

Note: This job can only be run by maintainers. On PRs from forks, this command requires
that the PR author has enabled the Allow edits from maintainers option.

poetry lock job started... Check job output.

✅ poetry lock applied successfully.

aaronsteers · 2025-01-28T23:29:06Z

/autofix

Auto-Fix Job Info

This job attempts to auto-fix any linting or formating issues. If any fixes are made,
those changes will be automatically committed and pushed back to the PR.

Note: This job can only be run by maintainers. On PRs from forks, this command requires
that the PR author has enabled the Allow edits from maintainers option.

PR auto-fix job started... Check job output.

✅ Changes applied successfully.

Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: Aaron <AJ> Steers <[email protected]>

natikgadzhi · 2025-01-29T05:33:47Z

This is great! Did we actually remove all pendulum types from public apis? I think there were a few connectors heavily coupled with it?

devin-ai-integration bot and others added 3 commits January 23, 2025 18:41

refactor: update datetime_helpers.py to handle Unix timestamps

eb72904

Co-Authored-By: Aaron <AJ> Steers <[email protected]>

aaronsteers marked this pull request as ready for review January 23, 2025 21:03

devin-ai-integration bot and others added 2 commits January 23, 2025 21:12

refactor: improve timestamp handling in OAuth authenticator

2119d00

Co-Authored-By: Aaron <AJ> Steers <[email protected]>

Merge branch 'main' into devin/1737657683-remove-pendulum

b2e678d

aaronsteers changed the title ~~refactor: remove pendulum dependency~~ chore: remove pendulum dependency Jan 23, 2025

Auto-commit Updating dependencies

6d34716

Resolving dependencies... changes

github-actions bot added the chore label Jan 23, 2025

aaronsteers reviewed Jan 23, 2025

View reviewed changes

pyproject.toml Outdated Show resolved Hide resolved

Update pyproject.toml

15d9a09

coderabbitai bot approved these changes Jan 23, 2025

View reviewed changes

devin-ai-integration bot and others added 14 commits January 23, 2025 22:12

fix: update datetime handling in tests and OAuth authenticator

bd511b4

Co-Authored-By: Aaron <AJ> Steers <[email protected]>

chore: fix import organization in test_model_to_component_factory.py

b970417

Co-Authored-By: Aaron <AJ> Steers <[email protected]>

fix: ensure OAuth token expiry only accepts seconds when no format sp…

6cb8071

…ecified Co-Authored-By: Aaron <AJ> Steers <[email protected]>

fix: improve datetime parsing and validation in OAuth authenticator

57c58f5

Co-Authored-By: Aaron <AJ> Steers <[email protected]>

Merge branch 'main' into devin/1737657683-remove-pendulum

5333a3f

fix: ensure consistent datetime string format with Z timezone

28f271a

Co-Authored-By: Aaron <AJ> Steers <[email protected]>

Merge remote-tracking branch 'origin/devin/1737657683-remove-pendulum'

2767c20

Co-Authored-By: Aaron <AJ> Steers <[email protected]>

chore: fix datetime_helpers.py formatting

b26e754

Co-Authored-By: Aaron <AJ> Steers <[email protected]>

test: update datetime test expectations to use Z timezone format

332246c

Co-Authored-By: Aaron <AJ> Steers <[email protected]>

test: improve datetime_helpers.py test coverage

9a433dc

Co-Authored-By: Aaron <AJ> Steers <[email protected]>

fix: correct timestamp handling in datetime_helpers.py

92537b3

Co-Authored-By: Aaron <AJ> Steers <[email protected]>

test: update OAuth test expectations to use Z timezone format

ba7690e

Co-Authored-By: Aaron <AJ> Steers <[email protected]>

fix: correct Unix timestamp handling in datetime_helpers.py

713dbc4

Co-Authored-By: Aaron <AJ> Steers <[email protected]>

fix: improve datetime formatting and test organization

f3ab290

Co-Authored-By: Aaron <AJ> Steers <[email protected]>

devin-ai-integration bot and others added 2 commits January 24, 2025 23:42

refactor: update UTC timezone representation from Z to +00:00

af48bb6

Co-Authored-By: Aaron <AJ> Steers <[email protected]>

feat: change UTC timezone format to +00:00 and integrate whenever lib…

898f4f5

…rary Co-Authored-By: Aaron <AJ> Steers <[email protected]>

devin-ai-integration bot force-pushed the devin/1737657683-remove-pendulum branch from 507a241 to 898f4f5 Compare January 25, 2025 01:38

devin-ai-integration bot and others added 10 commits January 25, 2025 01:41

style: fix formatting with ruff

3aac0e9

Co-Authored-By: Aaron <AJ> Steers <[email protected]>

test: update test expectations for UTC timezone format

f7c3b0e

Co-Authored-By: Aaron <AJ> Steers <[email protected]>

test: update more test expectations for UTC timezone format

332dc86

Co-Authored-By: Aaron <AJ> Steers <[email protected]>

test: remove duplicate test cases for invalid timestamps

7f95946

Co-Authored-By: Aaron <AJ> Steers <[email protected]>

fix: add timezone offset validation

663a685

Co-Authored-By: Aaron <AJ> Steers <[email protected]>

fix: improve timezone offset validation

ab3af8b

Co-Authored-By: Aaron <AJ> Steers <[email protected]>

misc fixes

c06108f

fix dateutil version

cff0086

clean up helpers

6b3055a

Merge branch 'main' into devin/1737657683-remove-pendulum

72d3e88

Auto-commit Resolving dependencies... changes

0d6a358

octavia-squidington-iii and others added 3 commits January 28, 2025 23:30

Auto-fix lint and format issues

8291d71

fix: improve datetime parsing validation and error messages (#289)

2a6faa9

Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: Aaron <AJ> Steers <[email protected]>

chore: remove stray Pendulum references (#290)

e8abad3

Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: Aaron <AJ> Steers <[email protected]>

This was referenced Jan 29, 2025

chore: remove stray Pendulum references #290

Merged

ci: add Python 3.12 support #291

Merged

aaronsteers approved these changes Jan 29, 2025

View reviewed changes

Merge branch 'main' into devin/1737657683-remove-pendulum

160d97d

aaronsteers requested review from natikgadzhi, bnchrch and maxi297 January 29, 2025 04:12

aaronsteers enabled auto-merge (squash) January 29, 2025 04:20

aaronsteers merged commit ad20739 into main Jan 29, 2025
24 of 27 checks passed

aaronsteers deleted the devin/1737657683-remove-pendulum branch January 29, 2025 04:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore: remove pendulum dependency #258

chore: remove pendulum dependency #258

Uh oh!

devin-ai-integration bot commented Jan 23, 2025 •

edited by aaronsteers

Loading

Uh oh!

devin-ai-integration bot commented Jan 23, 2025

Uh oh!

devin-ai-integration bot commented Jan 23, 2025

Uh oh!

aaronsteers commented Jan 23, 2025 •

edited by github-actions bot

Loading

Uh oh!

devin-ai-integration bot commented Jan 23, 2025

Uh oh!

Uh oh!

aaronsteers commented Jan 28, 2025 •

edited by github-actions bot

Loading

Uh oh!

aaronsteers commented Jan 28, 2025 •

edited by github-actions bot

Loading

Uh oh!

Uh oh!

natikgadzhi commented Jan 29, 2025

Uh oh!

Uh oh!

chore: remove pendulum dependency #258

chore: remove pendulum dependency #258

Uh oh!

Conversation

devin-ai-integration bot commented Jan 23, 2025 • edited by aaronsteers Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What

How

Testing

Uh oh!

devin-ai-integration bot commented Jan 23, 2025

Uh oh!

devin-ai-integration bot commented Jan 23, 2025

🤖 Devin AI Engineer

Uh oh!

aaronsteers commented Jan 23, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

devin-ai-integration bot commented Jan 23, 2025

Uh oh!

Uh oh!

aaronsteers commented Jan 28, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aaronsteers commented Jan 28, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

natikgadzhi commented Jan 29, 2025

Uh oh!

Uh oh!

devin-ai-integration bot commented Jan 23, 2025 •

edited by aaronsteers

Loading

aaronsteers commented Jan 23, 2025 •

edited by github-actions bot

Loading

aaronsteers commented Jan 28, 2025 •

edited by github-actions bot

Loading

aaronsteers commented Jan 28, 2025 •

edited by github-actions bot

Loading